Skip to content

Replace proposal-class-private-properties by regular properties #27265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Jun 2, 2021
Merged

Replace proposal-class-private-properties by regular properties #27265

skjnldsv merged 1 commit into from
Jun 2, 2021

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented May 29, 2021 •
edited
Loading

  • Get closer to the rfc instead of using a feature that doesn't seems close to be released
  • Solves all the vue reactivity issues

@skjnldsv skjnldsv self-assigned this May 29, 2021
@skjnldsv skjnldsv added 2. developing Work in progress bug labels May 29, 2021
@skjnldsv skjnldsv added this to the Nextcloud 22 milestone May 29, 2021
@blizzz blizzz mentioned this pull request Jun 2, 2021
Merged
57 tasks
@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 2, 2021

/compile amend /

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 2, 2021
@skjnldsv skjnldsv force-pushed the fix/private-class-properties branch from 936eb95 to 6a46012 Compare June 2, 2021 15:06
@skjnldsv @npmbuildbot-nextcloud
Replace proposal-class-private-properties by regular properties
aef00dd 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the fix/private-class-properties branch from 6a46012 to aef00dd Compare June 2, 2021 15:10
@skjnldsv skjnldsv requested a review from PVince81 June 2, 2021 15:22
@skjnldsv skjnldsv mentioned this pull request Jun 2, 2021
Merged
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 2, 2021
@skjnldsv skjnldsv merged commit 9498f44 into master Jun 2, 2021
@skjnldsv skjnldsv deleted the fix/private-class-properties branch June 2, 2021 16:58
@MorrisJobke MorrisJobke mentioned this pull request Jun 10, 2021
Merged
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz blizzz approved these changes

@Pytal Pytal Pytal approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@artonge artonge Awaiting requested review from artonge

@julien-nc julien-nc Awaiting requested review from julien-nc

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv @blizzz @Pytal