Skip to content

Conversation

@nickvergessen
Copy link
Member

There were 52 warnings:

1) lib\AppFramework\Bootstrap\CoordinatorTest::testBootAppNotLoadable
Trying to configure method "logException" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) lib\AppFramework\Bootstrap\RegistrationContextTest::testRegisterCapability
Trying to configure method "logException" which cannot be configured because it does not exist, has not been specified, is final, or is static

3) lib\AppFramework\Bootstrap\RegistrationContextTest::testRegisterEventListener
Trying to configure method "logException" which cannot be configured because it does not exist, has not been specified, is final, or is static

4) lib\AppFramework\Bootstrap\RegistrationContextTest::testRegisterService with data set #0 (true)
Trying to configure method "logException" which cannot be configured because it does not exist, has not been specified, is final, or is static

5) lib\AppFramework\Bootstrap\RegistrationContextTest::testRegisterService with data set #1 (false)
Trying to configure method "logException" which cannot be configured because it does not exist, has not been specified, is final, or is static

6) lib\AppFramework\Bootstrap\RegistrationContextTest::testRegisterServiceAlias
Trying to configure method "logException" which cannot be configured because it does not exist, has not been specified, is final, or is static

7) lib\AppFramework\Bootstrap\RegistrationContextTest::testRegisterParameter
Trying to configure method "logException" which cannot be configured because it does not exist, has not been specified, is final, or is static

8) lib\AppFramework\Bootstrap\RegistrationContextTest::testRegisterMiddleware
Trying to configure method "logException" which cannot be configured because it does not exist, has not been specified, is final, or is static

9) Test\AppFramework\Middleware\Security\SecurityMiddlewareTest::testAfterExceptionReturnsRedirectForNotLoggedInUser
Trying to configure method "logException" which cannot be configured because it does not exist, has not been specified, is final, or is static

10) Test\AppFramework\Middleware\Security\SecurityMiddlewareTest::testAfterExceptionReturnsTemplateResponse with data set #0 (OC\AppFramework\Middleware\Security\Exceptions\AppNotEnabledException Object (...))
Trying to configure method "logException" which cannot be configured because it does not exist, has not been specified, is final, or is static

11) Test\AppFramework\Middleware\Security\SecurityMiddlewareTest::testAfterExceptionReturnsTemplateResponse with data set #1 (OC\AppFramework\Middleware\Security\Exceptions\CrossSiteRequestForgeryException Object (...))
Trying to configure method "logException" which cannot be configured because it does not exist, has not been specified, is final, or is static

12) Test\AppFramework\Middleware\Security\SecurityMiddlewareTest::testAfterExceptionReturnsTemplateResponse with data set #2 (OC\AppFramework\Middleware\Security\Exceptions\NotAdminException Object (...))
Trying to configure method "logException" which cannot be configured because it does not exist, has not been specified, is final, or is static

13) Test\CapabilitiesManagerTest::testInvalidCapability
Trying to configure method "logException" which cannot be configured because it does not exist, has not been specified, is final, or is static

14) Test\Collaboration\Resources\ProviderManagerTest::testGetResourceProvidersInvalidProvider
Trying to configure method "logException" which cannot be configured because it does not exist, has not been specified, is final, or is static

15) Test\Collaboration\Resources\ProviderManagerTest::testGetResourceProvidersValidAndInvalidProvider
Trying to configure method "logException" which cannot be configured because it does not exist, has not been specified, is final, or is static

16) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarOperations
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

17) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarSharing with data set #0 (true, true, true, false, array(array('principal:principals/users/ca...-test1', false), array('principal:principals/groups/c...-group', true)))
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

18) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarSharing with data set #1 (true, true, true, false, array(array('principal:principals/groups/c...-group', true), array('principal:principals/groups/c...group2', false)))
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

19) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarSharing with data set #2 (true, true, true, true, array(array('principal:principals/groups/c...-group', false), array('principal:principals/groups/c...group2', true)))
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

20) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarSharing with data set #3 (true, false, false, false, array(array('principal:principals/users/ca...-test1', true)))
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

21) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarObjectsOperations
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

22) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testMultipleCalendarObjectsWithSameUID
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

23) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testMultiCalendarObjects
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

24) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "all" (array(0, 1, 2, 3), array(), array())
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

25) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "only-todos" (array(), array('VTODO'), array())
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

26) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "only-events" (array(0, 1, 2, 3), array(), array(array('VEVENT', false, array(), array(null, null), array())))
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

27) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "start" (array(1, 2, 3), array(), array(array('VEVENT', false, array(), array(DateTime Object (...), null), array())))
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

28) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "end" (array(0), array(), array(array('VEVENT', false, array(), array(null, DateTime Object (...)), array())))
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

29) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarQuery with data set "future" (array(3), array(), array(array('VEVENT', false, array(), array(DateTime Object (...), null), array())))
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

30) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testGetCalendarObjectByUID
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

31) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testSyncSupport
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

32) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testPublications
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

33) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testSubscriptions
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

34) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testScheduling with data set "no data" ('')
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

35) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testScheduling with data set "failing on postgres" ('BEGIN:VCALENDAR\nVERSION:2.0\...LENDAR')
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

36) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testGetDenormalizedData with data set "first occurrence before unix epoch starts" (0, 'firstOccurence', 'BEGIN:VCALENDAR\r\nVERSION:2....AR\r\n')
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

37) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testGetDenormalizedData with data set "no first occurrence because yearly" (null, 'firstOccurence', 'BEGIN:VCALENDAR\r\nVERSION:2....AR\r\n')
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

38) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testGetDenormalizedData with data set "last occurrence is max when only last VEVENT in group is weekly" (2145916800, 'lastOccurence', 'BEGIN:VCALENDAR\r\nVERSION:2....AR\r\n')
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

39) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testGetDenormalizedData with data set "first occurrence is found when not first VEVENT in group" (1598983200, 'firstOccurence', 'BEGIN:VCALENDAR\r\nVERSION:2....AR\r\n')
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

40) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testGetDenormalizedData with data set "CLASS:PRIVATE" (1, 'classification', 'BEGIN:VCALENDAR\r\nVERSION:2....LENDAR')
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

41) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testGetDenormalizedData with data set "CLASS:PUBLIC" (0, 'classification', 'BEGIN:VCALENDAR\r\nVERSION:2....LENDAR')
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

42) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testGetDenormalizedData with data set "CLASS:CONFIDENTIAL" (2, 'classification', 'BEGIN:VCALENDAR\r\nVERSION:2....LENDAR')
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

43) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testGetDenormalizedData with data set "no class set -> public" (0, 'classification', 'BEGIN:VCALENDAR\r\nVERSION:2....LENDAR')
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

44) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testGetDenormalizedData with data set "unknown class -> private" (1, 'classification', 'BEGIN:VCALENDAR\r\nVERSION:2....LENDAR')
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

45) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarSearch
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

46) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testSearch with data set #0 (false, array(), 4)
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

47) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testSearch with data set #1 (true, array(array(DateTime Object (...), DateTime Object (...))), 2)
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

48) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testSearch with data set #2 (true, array(array(DateTime Object (...), DateTime Object (...))), 0)
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

49) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testSameUriSameIdForDifferentCalendarTypes
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

50) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testPurgeAllCachedEventsForSubscription
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

51) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testCalendarMovement
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

52) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testSearchPrincipal
Trying to configure method "dispatchTyped" which cannot be configured because it does not exist, has not been specified, is final, or is static

$this->dispatcher->expects(self::any())
->method('dispatchTyped');
$this->legacyDispatcher->expects(self::any())
->method('dispatch');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChristophWurst feel free to fix this differently if you want to specific, I failed to list all the classes and do the counting correctly.

@nickvergessen nickvergessen mentioned this pull request Jun 4, 2021
@skjnldsv
Copy link
Member

skjnldsv commented Jun 4, 2021

php-cs says nono

Signed-off-by: Morris Jobke <[email protected]>
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the code style and this now looks good 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 7, 2021
@MorrisJobke MorrisJobke merged commit 92d19bd into master Jun 7, 2021
@MorrisJobke MorrisJobke deleted the bugfix/noid/adjust-unit-tests branch June 7, 2021 09:12
@MorrisJobke MorrisJobke mentioned this pull request Jun 10, 2021
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants