[stable19] avoid fread on directories and unencrypted files #27405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
requested review from
danxuliu,
icewind1991,
jknockaert,
juliusknorr,
kesselb,
rullzer,
schiessle and
vitormattos
Member
|
@jknockaert i've applied this patch, but i'm now having these errors:
|
Contributor
|
@acsfer I'm no longer having any such errors after I disabled the encryption app. |
Member
|
Oh, ok, so this doens't fix these errors while encryption is enabled, right? |
Contributor
|
@acsfer I wouldn't know if it (still) fixes any errors while encryption is enabled. |
added 7 commits
July 1, 2021 11:44
Reworking the logic in order to first check the filecache and only then reading the fileheader. This in order to solve #21578.
Signed-off-by: Jasper Knockaert [email protected]
skjnldsv
force-pushed
the
backport/24966/stable19
branch
from
087d360 to
1c3fe81
Compare
Contributor
|
@acsfer yes it dose fix the errors while encryption is enabled I tested it on vs 19, 20, 21 |
AndyXheli
approved these changes
Jul 3, 2021
Contributor
AndyXheli
left a comment
AndyXheli
left a comment
There was a problem hiding this comment.
This dose fix the issue
Member
|
19 is EOL, please upgrade to 20 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #24966