Skip to content

Don't pass a column object to addOrderBy #27429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristophWurst merged 1 commit into from
Jun 9, 2021
Merged

Don't pass a column object to addOrderBy #27429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix #26085 
addOrderBy expects a order expression. For the migration scenario we have column objects. Column objects are not supported by quoteColumnName yet.

A column object as order expression is most likely an edgy thing when migration database information.

Signed-off-by: Daniel Kesselberg <[email protected]>
  • Loading branch information
@kesselb
kesselb committed Jun 8, 2021
commit 11cacf63f8249561b856d6283b6b7a7fcfb3bdad
7 changes: 2 additions & 5 deletions core/Command/Db/ConvertType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,14 +337,11 @@ protected function copyTable(Connection $fromDB, Connection $toDB, Table $table,
try {
$orderColumns = $table->getPrimaryKeyColumns();
} catch (Exception $e) {
$orderColumns = [];
foreach ($table->getColumns() as $column) {
$orderColumns[] = $column->getName();
}
$orderColumns = $table->getColumns();
}

foreach ($orderColumns as $column) {
$query->addOrderBy($column);
$query->addOrderBy($column->getName());
}

$insertQuery = $toDB->getQueryBuilder();
Expand Down