Allow apps to get photos of VObjects #27436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
skjnldsv
reviewed
Jun 9, 2021
skjnldsv
reviewed
Jun 9, 2021
skjnldsv
approved these changes
Jun 9, 2021
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Aside from two minor code improvements, I'm fine
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
techdebt/noid/all-apps-to-get-photos-from-vobjects-too
branch
from
9861eaf to
b1031f3
Compare
ChristophWurst
approved these changes
Jun 9, 2021
skjnldsv
deleted the
techdebt/noid/all-apps-to-get-photos-from-vobjects-too
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Talk we want to show the name and photo of a contact instead of the vcard mimetype icon and the file name (nextcloud/spreed#5731)
Instead of reimplementing the photo parsing and type checking I'd like to use this part from the DAV app, so in case something is fixed/extended there it also works in Talk