Skip to content

Fix avatar actions #27506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PVince81 merged 1 commit into from
Jun 15, 2021
Merged

Fix avatar actions #27506

PVince81 merged 1 commit into from
Jun 15, 2021

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jun 15, 2021

Steps

  1. Try to pick an avatar from existing files
Access forbidden
CSRF check failed

Steps

  1. Upload an avatar
  2. Delete the avatar
Access forbidden
CSRF check failed
  1. But avatar is gone if you go back.

Cause

Regression from 64e90cd as the buttons submit the form around it.

@nickvergessen
Fix avatar actions
cd8386b 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen added this to the Nextcloud 22 milestone Jun 15, 2021
PVince81
PVince81 approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit cc4e663 into master Jun 15, 2021
@PVince81 PVince81 deleted the bugfix/noid/fix-avatar-actions branch June 15, 2021 11:49
@nickvergessen nickvergessen mentioned this pull request Jun 15, 2021
Merged
@blizzz blizzz mentioned this pull request Jun 16, 2021
Merged
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: settings

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @PVince81 @skjnldsv