Skip to content

Add return type for writeToCache #27512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kesselb merged 1 commit into from
Jun 15, 2021
Merged

Add return type for writeToCache #27512

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add return type for writeToCache 
writeToCache does not return a string.

Signed-off-by: Daniel Kesselberg <[email protected]>
  • Loading branch information
@kesselb
kesselb committed Jun 15, 2021
commit 33801708d29d44e9e1b2221af6778020ea689c50
6 changes: 2 additions & 4 deletions apps/user_ldap/lib/Connection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,17 +256,15 @@ public function getFromCache($key) {
/**
* @param string $key
* @param mixed $value
*
* @return string
*/
public function writeToCache($key, $value) {
public function writeToCache($key, $value): void {
if (!$this->configured) {
$this->readConfiguration();
}
if (is_null($this->cache)
|| !$this->configuration->ldapCacheTTL
|| !$this->configuration->ldapConfigurationActive) {
return null;
return;
}
$key = $this->getCacheKey($key);
$value = base64_encode(json_encode($value));
Expand Down