Skip to content

[stable19] Throttle on public DAV endpoint #27618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LukasReschke merged 6 commits into from
Jun 23, 2021
Merged

[stable19] Throttle on public DAV endpoint #27618

LukasReschke merged 6 commits into from
Jun 23, 2021

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Jun 23, 2021

backport of #27610

@LukasReschke @backportbot
Throttle on public DAV endpoint
80a40fd 
We should throttle whenever an invalid request is sent to the public WebDAV endpoint.

Signed-off-by: Lukas Reschke <[email protected]>
@LukasReschke @backportbot
Reference correct private variable
6ad4ef8 
Signed-off-by: Lukas Reschke <[email protected]>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 19.0.13 milestone Jun 23, 2021
@blizzz blizzz mentioned this pull request Jun 23, 2021
Merged
2 tasks
@LukasReschke
Copy link
Member

LukasReschke commented Jun 23, 2021 

lukasreschke@Lukass-Air server % curl -u "RANDOM1:RANDOM2" -X PROPFIND http://localhost:8081/public.php/webdav
<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Error</s:exception>
  <s:message>Call to undefined method OC\Security\Bruteforce\Throttler::sleepDelayOrThrowOnMax()</s:message>
</d:error>

@LukasReschke LukasReschke force-pushed the backport/27610/stable19 branch from ed71d37 to 6f23221 Compare June 23, 2021 10:27
LukasReschke and others added 2 commits June 23, 2021 15:06
@LukasReschke
Update autoloader map
9588fb0 
Signed-off-by: Lukas Reschke <[email protected]>
@nickvergessen @LukasReschke
More test fixing
4b558cd 
Signed-off-by: Joas Schilling <[email protected]>
@LukasReschke
Copy link
Member

LukasReschke commented Jun 23, 2021

Errors seem unrelated.

@LukasReschke LukasReschke merged commit 159762d into stable19 Jun 23, 2021
@LukasReschke LukasReschke deleted the backport/27610/stable19 branch June 23, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@LukasReschke LukasReschke LukasReschke approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Nextcloud 19.0.13

Development

Successfully merging this pull request may close these issues.

3 participants

@LukasReschke @nickvergessen