Correctly skip suppressed errors in PHP 8.0 #27631

yan12125 · 2021-06-23T12:52:11Z

Applies the suggested transformation mentioned in
https://www.php.net/manual/en/migration80.incompatible.php,

The @ operator will no longer silence fatal errors (E_ERROR,
E_CORE_ERROR, E_COMPILE_ERROR, E_USER_ERROR, E_RECOVERABLE_ERROR,
E_PARSE). Error handlers that expect error_reporting to be 0 when
@ is used, should be adjusted to use a mask check instead

The new code still works on PHP 7, as error_reporting() already
returns 0 when diagnostics are suppressed.

This fixes #25807 in PHP 8.0.
For PHP 7.x, #22243 suppresses
the E_NOTICE message from the second session_start() call with the error
suppression operator @, and thus those E_NOTICE messages are still
logged in PHP 8.0.

See also #25806

Signed-off-by: Chih-Hsuan Yen [email protected]

yan12125 · 2021-06-23T12:54:12Z

As a side note: other error_reporting() calls in Nextcloud already uses the mask pattern

lib/private/Log/ErrorHandler.php:		if (!(error_reporting() & $number)) {
lib/base.php:			error_reporting(E_ALL);
apps/files/lib/Command/Scan.php:		if (!(error_reporting() & $severity)) {
apps/files/lib/Command/Scan.php:			// This error code is not included in error_reporting
apps/files/lib/Command/ScanAppData.php:		if (!(error_reporting() & $severity)) {
apps/files/lib/Command/ScanAppData.php:			// This error code is not included in error_reporting

szaimen · 2021-06-23T13:07:28Z

cc @skjnldsv, @eneiluj, @icewind1991 and @ArtificialOwl for feedback on this

yan12125 · 2021-06-23T14:54:39Z

Hmm I'm not sure if I understand the failed test. Drone CI [1] reports that "And I see that the new user form is shown" failed, while the new user form seems fine with my patched installation.

[1] https://drone.nextcloud.com/nextcloud/server/6543/62/4

yan12125 · 2021-06-25T06:44:58Z

After rebasing onto the latest git-master, the acceptance-login test becomes green but sqlite and integration-sharing-v1-video-verification turn red. I think those are unstable tests like ones listed in #22305

AndyXheli · 2021-07-06T19:41:45Z

Tested on NC 22 and looks good.

juliusknorr

Makes sense 👍

szaimen · 2021-07-07T10:00:31Z

Not sure if this is important:

There was 1 failure:
407 |  
408 | 1) Test\Files\Cache\UpdaterLegacyTest::testWrite
409 | Failed asserting that 1624596572 is equal to 1624596573 or is greater than 1624596573.
410 |  
411 | /drone/src/tests/lib/Files/Cache/UpdaterLegacyTest.php:118

yan12125 · 2021-07-07T10:09:36Z

Checking again, the failure in UpdaterLegacyTest.php is mentioned as an unstable test at #22305 (comment)

yan12125 · 2021-07-09T02:52:50Z

Hmm, how can I proceed here? GitHub refuses to merge this PR as some tests failed.

Also, could this be backported to versions that declare PHP 8 support (stable-22 and stable-21)?

skjnldsv · 2021-07-09T06:40:35Z

Can you rebase to master please @yan12125 ?

yan12125 · 2021-07-09T07:39:00Z

Can you rebase to master please @yan12125 ?

Done! Previous failures are green this time, but there is a new failure, and it is not mentioned in #22305

  Scenario: users navigation without disabled users                                   # /drone/src/tests/acceptance/features/users.feature:48
    Given I act as Jane                                                               # ActorContext::iActAs()
    And I am logged in as the admin                                                   # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                                      # SettingsMenuContext::iOpenTheUserSettings()
    And I open the "Disabled users" section                                           # AppNavigationContext::iOpenTheSection()
    And I see that the list of users contains the user disabledUser                   # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
      The user disabledUser in the list of users is not shown yet after 100 seconds
    And I open the actions menu for the user disabledUser                             # UsersSettingsContext::iOpenTheActionsMenuOf()
    And I see that the "Enable user" action in the disabledUser actions menu is shown # UsersSettingsContext::iSeeTheAction()
    When I click the "Enable user" action in the disabledUser actions menu            # UsersSettingsContext::iClickTheAction()
    Then I see that the section "Disabled users" is not shown                         # AppNavigationContext::iSeeThatTheSectionIsNotShown()
    When I open the User settings                                                     # SettingsMenuContext::iOpenTheUserSettings()
    Then I see that the section "Disabled users" is not shown                         # AppNavigationContext::iSeeThatTheSectionIsNotShown()

nickvergessen · 2021-07-09T09:33:55Z

That's okay and unrelated I think

yan12125 · 2021-07-09T16:13:21Z

Thanks! But GitHub still insists on green for all tests 😂

Applies the suggested transformation mentioned in https://www.php.net/manual/en/migration80.incompatible.php, > The @ operator will no longer silence fatal errors (E_ERROR, > E_CORE_ERROR, E_COMPILE_ERROR, E_USER_ERROR, E_RECOVERABLE_ERROR, > E_PARSE). Error handlers that expect error_reporting to be 0 when > @ is used, should be adjusted to use a mask check instead The new code still works on PHP 7, as error_reporting() already returns 0 when diagnostics are suppressed. This fixes #25807 in PHP 8.0. For PHP 7.x, #22243 suppresses the E_NOTICE message from the second session_start() call with the error suppression operator @, and thus those E_NOTICE messages are still logged in PHP 8.0. See also #25806 Signed-off-by: Chih-Hsuan Yen <[email protected]>

juliusknorr · 2021-07-13T06:52:44Z

/backport to stable22

juliusknorr · 2021-07-13T06:52:48Z

/backport to stable21

backportbot-nextcloud · 2021-07-13T10:53:34Z

The backport to stable21 failed. Please do this backport manually.

backportbot-nextcloud · 2021-07-13T10:53:50Z

The backport to stable22 failed. Please do this backport manually.

yan12125 · 2021-07-13T11:37:53Z

Hmm strange. Created manual backports #27938 and #27939. Hopefully I'm doing it right :)

juliusknorr · 2021-07-13T12:01:08Z

Looks good :) Thanks for already taking care of that 👍

yan12125 · 2021-07-14T12:41:41Z

Hmm is this needed on stable20? The latter does not declare support for PHP 8.0 [1]. I guess it will not bring errors, though.

[1] https://github.com/nextcloud/server/blob/stable20/lib/versioncheck.php

MichaIng · 2021-07-14T13:09:19Z

Ah that is true, if fails even when overriding the check, due to broader incompatibility. The bot is sleeping anyway 😄.

szaimen added this to the Nextcloud 22 milestone Jun 23, 2021

szaimen added the 3. to review Waiting for reviews label Jun 23, 2021

blizzz mentioned this pull request Jun 23, 2021

22.0.0 RC1 #27623

Merged

39 tasks

blizzz modified the milestones: Nextcloud 22, Nextcloud 23 Jun 24, 2021

kesselb mentioned this pull request Jul 1, 2021

Error: Couldn't get xattr for smb://10.241.202.20/NextcloudShare/readme.md: unknown error (2) at /var/www/nextcloud/apps/files_external/3rdparty/icewind/smb/src/Native/NativeState.php#336 #27738

Closed

kesselb added the bug label Jul 5, 2021

szaimen requested review from ChristophWurst and icewind1991 July 6, 2021 08:24

skjnldsv requested review from blizzz, juliusknorr and nickvergessen July 7, 2021 06:03

juliusknorr approved these changes Jul 7, 2021

View reviewed changes

nickvergessen approved these changes Jul 7, 2021

View reviewed changes

yan12125 mentioned this pull request Jul 9, 2021

Nextcloud 21 - Error: session_start(): Ignoring session_start() because a session is already active #25807

Closed

This comment has been minimized.

Sign in to view

skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 9, 2021

juliusknorr merged commit e1f644a into nextcloud:master Jul 13, 2021

backportbot-nextcloud bot added the backport-request label Jul 13, 2021

yan12125 deleted the php8-fix-error-reporting branch July 13, 2021 07:25

yan12125 mentioned this pull request Jul 13, 2021

Several incompatibilites with PHP 8.0 #25806

Closed

This was referenced Jul 13, 2021

[stable22] Correctly skip suppressed errors in PHP 8.0 #27938

Merged

[stable21] Correctly skip suppressed errors in PHP 8.0 #27939

Merged

juliusknorr removed the backport-request label Jul 13, 2021

Uh oh!

Correctly skip suppressed errors in PHP 8.0 #27631

Correctly skip suppressed errors in PHP 8.0 #27631

Uh oh!

Conversation

yan12125 commented Jun 23, 2021

Uh oh!

yan12125 commented Jun 23, 2021

Uh oh!

szaimen commented Jun 23, 2021

Uh oh!

yan12125 commented Jun 23, 2021

Uh oh!

yan12125 commented Jun 25, 2021

Uh oh!

AndyXheli commented Jul 6, 2021

Uh oh!

juliusknorr left a comment

Choose a reason for hiding this comment

Uh oh!

szaimen commented Jul 7, 2021

Uh oh!

yan12125 commented Jul 7, 2021

Uh oh!

yan12125 commented Jul 9, 2021

Uh oh!

This comment has been minimized.

skjnldsv commented Jul 9, 2021

Uh oh!

yan12125 commented Jul 9, 2021

Uh oh!

nickvergessen commented Jul 9, 2021

Uh oh!

yan12125 commented Jul 9, 2021

Uh oh!

juliusknorr commented Jul 13, 2021

Uh oh!

juliusknorr commented Jul 13, 2021

Uh oh!

backportbot-nextcloud bot commented Jul 13, 2021

Uh oh!

backportbot-nextcloud bot commented Jul 13, 2021

Uh oh!

yan12125 commented Jul 13, 2021

Uh oh!

juliusknorr commented Jul 13, 2021

Uh oh!

yan12125 commented Jul 14, 2021

Uh oh!

MichaIng commented Jul 14, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants