Remember current cipher #27644
Merged
Remember current cipher #27644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0WI
added
3. to review
J0WI
force-pushed
the
remember-cipher
branch
3 times, most recently
from
cef2caf to
8c3a5ad
Compare
J0WI
force-pushed
the
remember-cipher
branch
2 times, most recently
from
a0b31d5 to
349bf8a
Compare
ChristophWurst
requested changes
Jun 29, 2021
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Static analysis complains that the property isn't initialized
Signed-off-by: J0WI <[email protected]>
LukasReschke
approved these changes
Jun 29, 2021
J0WI
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #26323
In my case
getCipher()is about 15 times faster and this function is called for each file.