Unshift crash reports when they are loaded, to break the recusion #27663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If, for whatever reason, during the loading of a crash reporter a new log entry is generated, then the lazy loading mechanism will be invoked *again* while it's already executed. This doesn't result in an endless recursion, but means that the crash reporters will be built and registered many times. This then means any further log entry will be logged x times instead of once. Unshift makes sure to take the class off the registration list right away, so another invokation of the same method won't try to do the same job. Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
requested review from
Pytal,
juliusknorr,
miaulalala,
nickvergessen,
skjnldsv and
solracsf
Member
Author
|
/backport to stable22 |
Member
Author
|
/backport to stable21 |
Pytal
approved these changes
Jun 24, 2021
skjnldsv
approved these changes
Jun 25, 2021
Member
|
Failure unrelated |
This was referenced Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If, for whatever reason, during the loading of a crash reporter a new
log entry is generated, then the lazy loading mechanism will be invoked
again while it's already executed. This doesn't result in an endless
recursion, but means that the crash reporters will be built and
registered many times. This then means any further log entry will be
logged x times instead of once.
Unshift makes sure to take the class off the registration list right
away, so another invocation of the same method won't try to do the same
job.
Found while trying to bring the Sentry app to 21/22.