Skip to content

Conversation

@nickvergessen
Copy link
Member

Forgot this in #27648

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Jun 24, 2021
@nickvergessen nickvergessen added this to the Nextcloud 23 milestone Jun 24, 2021
@skjnldsv
Copy link
Member

Unit tests to be fixed

1) Tests\Core\Command\Config\AppsDisableTest::testCommandInput with data set #0 (array('admin_audit'), 0, 'admin_audit 1.11.0 disabled')
Failed asserting that 'admin_audit 1.12.0 disabled\n
' contains "admin_audit 1.11.0 disabled".

/home/runner/work/server/server/tests/Core/Command/Apps/AppsDisableTest.php:65

2) Tests\Core\Command\Config\AppsDisableTest::testCommandInput with data set #1 (array('comments'), 0, 'comments 1.11.0 disabled')
Failed asserting that 'comments 1.12.0 disabled\n
' contains "comments 1.11.0 disabled".

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the techdebt/noid/master-is-now-23-part2 branch from cb07daf to a651dbd Compare June 25, 2021 09:49
@nickvergessen nickvergessen requested a review from kesselb June 25, 2021 09:50
@skjnldsv skjnldsv merged commit 00edbc2 into master Jun 25, 2021
@skjnldsv skjnldsv deleted the techdebt/noid/master-is-now-23-part2 branch June 25, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants