Skip to content

hide download button for public preview of audio files #27674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szaimen merged 3 commits into from
Jul 21, 2021
Merged

hide download button for public preview of audio files #27674

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b6ff55
hide download button for public preview of audio files
fstorz Jun 25, 2021
6aed809
Add comment linking to PR
fstorz Jul 19, 2021
b803043
Remove trailing whitespace from comment
fstorz Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comment linking to PR 
PR contains discussion about the implementation with pros and cons

Signed-off-by: Florian Storz <[email protected]>
  • Loading branch information
@fstorz
fstorz committed Jul 19, 2021
commit 6aed80913ffee35dea250ab3d002bf0cd16f5f21
1 change: 1 addition & 0 deletions apps/files_sharing/templates/public.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
<?php if ($_['previewEnabled'] && substr($_['mimetype'], 0, strpos($_['mimetype'], '/')) == 'audio'): ?>
<div id="imgframe">
<audio tabindex="0" controls="" preload="none" style="width: 100%; max-width: <?php p($_['previewMaxX']); ?>px; max-height: <?php p($_['previewMaxY']); ?>px"
<?php // See https://github.com/nextcloud/server/pull/27674 ?>
<?php if ($_['hideDownload']) { ?>controlsList="nodownload" <?php } ?>>
<source src="<?php p($_['downloadURL']); ?>" type="<?php p($_['mimetype']); ?>" />
</audio>
Expand Down