Skip to content

[stable20] Fix svg icons disapearing in app navigation when text overflows #27955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaIng merged 1 commit into from
Jul 13, 2021
Merged

[stable20] Fix svg icons disapearing in app navigation when text overflows #27955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix svg icons disapearing in app navigation when text overflows 
The issue is caused by the icon being positionned with negative margins
and the `overflow: hidden` rule when hide the icon when the text
overflows. Remove positioning with negative margins. This was only
happening in Firefox.

This fix #23849

Signed-off-by: Carl Schwan <[email protected]>
  • Loading branch information
@CarlSchwan @backportbot
CarlSchwan authored and backportbot[bot] committed Jul 13, 2021
commit 1e88f2343b8aaa5cee238ef4ff3cbe6df2ff510d
7 changes: 5 additions & 2 deletions core/css/apps.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ kbd {
justify-content: space-between;
line-height: 44px;
min-height: 44px;
padding: 0 12px 0 44px;
padding: 0 12px 0 14px;
overflow: hidden;
box-sizing: border-box;
white-space: nowrap;
Expand All @@ -277,11 +277,14 @@ kbd {
flex: 1 1 0px;
z-index: 100; /* above the bullet to allow click*/
/* TODO: forbid using img as icon in menu? */

.svg {
padding: 0 12px 0 44px;
}
&:first-child img {
margin-right: 11px;
width: 16px;
height: 16px;
margin-left: -30px;
}

/* counter can also be inside the link */
Expand Down