Upgrade eslint-config to v6.0.0

.eslintignore

@@ -7,5 +7,24 @@ node_modules/
 *.config.js
 tests/lib/
 
+# Ignore all apps except for server apps
+apps/*
+!apps/accessibility
+!apps/comments
+!apps/dashboard
+!apps/dav
+!apps/files
+!apps/files_sharing
+!apps/files_trashbin
+!apps/files_versions
+!apps/oauth2
+!apps/settings
+!apps/systemtags
+!apps/user_status
+!apps/weather_status
+!apps/twofactor_backupcodes
+!apps/updatenotification
+!apps/workflowengine
+
 # TODO: remove when comments files is not using handlebar templates anymore
-apps/comments/src/templates.js
+apps/comments/src/templates.js

apps/comments/src/components/Comment.vue

@@ -166,15 +166,17 @@ export default {
 
 		/**
 		 * Is the current user the author of this comment
-		 * @returns {boolean}
+		 *
+		 * @return {boolean}
 		 */
 		isOwnComment() {
 			return getCurrentUser().uid === this.actorId
 		},
 
 		/**
 		 * Rendered content as html string
-		 * @returns {string}
+		 *
+		 * @return {string}
 		 */
 		renderedContent() {
 			if (this.isEmptyMessage) {
@@ -208,6 +210,7 @@ export default {
 	methods: {
 		/**
 		 * Update local Message on outer change
+		 *
 		 * @param {string} message the message to set
 		 */
 		updateLocalMessage(message) {

apps/comments/src/views/Comments.vue

@@ -126,7 +126,8 @@ export default {
 	methods: {
 		/**
 		 * Update current ressourceId and fetch new data
-		 * @param {Number} ressourceId the current ressourceId (fileId...)
+		 *
+		 * @param {number} ressourceId the current ressourceId (fileId...)
 		 */
 		async update(ressourceId) {
 			this.ressourceId = ressourceId
@@ -152,8 +153,9 @@ export default {
 
 		/**
 		 * Make sure we have all mentions as Array of objects
+		 *
 		 * @param {Array} mentions the mentions list
-		 * @returns {Object[]}
+		 * @return {object[]}
 		 */
 		genMentionsData(mentions) {
 			const list = Object.values(mentions).flat()
@@ -217,6 +219,7 @@ export default {
 
 		/**
 		 * Autocomplete @mentions
+		 *
 		 * @param {string} search the query
 		 * @param {Function} callback the callback to process the results with
 		 */
@@ -235,14 +238,16 @@ export default {
 
 		/**
 		 * Add newly created comment to the list
-		 * @param {Object} comment the new comment
+		 *
+		 * @param {object} comment the new comment
 		 */
 		onNewComment(comment) {
 			this.comments.unshift(comment)
 		},
 
 		/**
 		 * Remove deleted comment from the list
+		 *
 		 * @param {number} id the deleted comment
 		 */
 		onDelete(id) {

apps/dashboard/src/App.vue

@@ -264,7 +264,7 @@ export default {
 		 * Method to register panels that will be called by the integrating apps
 		 *
 		 * @param {string} app The unique app id for the widget
-		 * @param {function} callback The callback function to register a panel which gets the DOM element passed as parameter
+		 * @param {Function} callback The callback function to register a panel which gets the DOM element passed as parameter
 		 */
 		register(app, callback) {
 			Vue.set(this.callbacks, app, callback)

apps/dav/src/views/CalDavSettings.spec.js

@@ -31,7 +31,7 @@ describe('CalDavSettings', () => {
 		global.OCP = originalOCP
 	})
 
-	test('interactions', async() => {
+	test('interactions', async () => {
 		const TLUtils = render(
 			CalDavSettings,
 			{

apps/files/src/components/TemplatePreview.vue

@@ -102,7 +102,8 @@ export default {
 	computed: {
 		/**
 		 * Strip away extension from name
-		 * @returns {string}
+		 *
+		 * @return {string}
 		 */
 		nameWithoutExt() {
 			return this.basename.indexOf('.') > -1 ? this.basename.split('.').slice(0, -1).join('.') : this.basename

apps/files/src/views/Sidebar.vue

@@ -121,31 +121,35 @@ export default {
 		 * Current filename
 		 * This is bound to the Sidebar service and
 		 * is used to load a new file
-		 * @returns {string}
+		 *
+		 * @return {string}
 		 */
 		file() {
 			return this.Sidebar.file
 		},
 
 		/**
 		 * List of all the registered tabs
-		 * @returns {Array}
+		 *
+		 * @return {Array}
 		 */
 		tabs() {
 			return this.Sidebar.tabs
 		},
 
 		/**
 		 * List of all the registered views
-		 * @returns {Array}
+		 *
+		 * @return {Array}
 		 */
 		views() {
 			return this.Sidebar.views
 		},
 
 		/**
 		 * Current user dav root path
-		 * @returns {string}
+		 *
+		 * @return {string}
 		 */
 		davPath() {
 			const user = OC.getCurrentUser().uid
@@ -154,48 +158,54 @@ export default {
 
 		/**
 		 * Current active tab handler
+		 *
 		 * @param {string} id the tab id to set as active
-		 * @returns {string} the current active tab
+		 * @return {string} the current active tab
 		 */
 		activeTab() {
 			return this.Sidebar.activeTab
 		},
 
 		/**
 		 * Sidebar subtitle
-		 * @returns {string}
+		 *
+		 * @return {string}
 		 */
 		subtitle() {
 			return `${this.size}, ${this.time}`
 		},
 
 		/**
 		 * File last modified formatted string
-		 * @returns {string}
+		 *
+		 * @return {string}
 		 */
 		time() {
 			return OC.Util.relativeModifiedDate(this.fileInfo.mtime)
 		},
 
 		/**
 		 * File last modified full string
-		 * @returns {string}
+		 *
+		 * @return {string}
 		 */
 		fullTime() {
 			return moment(this.fileInfo.mtime).format('LLL')
 		},
 
 		/**
 		 * File size formatted string
-		 * @returns {string}
+		 *
+		 * @return {string}
 		 */
 		size() {
 			return OC.Util.humanFileSize(this.fileInfo.size)
 		},
 
 		/**
 		 * File background/figure to illustrate the sidebar header
-		 * @returns {string}
+		 *
+		 * @return {string}
 		 */
 		background() {
 			return this.getPreviewIfAny(this.fileInfo)
@@ -204,7 +214,7 @@ export default {
 		/**
 		 * App sidebar v-binding object
 		 *
-		 * @returns {Object}
+		 * @return {object}
 		 */
 		appSidebar() {
 			if (this.fileInfo) {
@@ -243,7 +253,7 @@ export default {
 		/**
 		 * Default action object for the current file
 		 *
-		 * @returns {Object}
+		 * @return {object}
 		 */
 		defaultAction() {
 			return this.fileInfo
@@ -260,7 +270,7 @@ export default {
 		 * nothing is listening for a click if there
 		 * is no default action
 		 *
-		 * @returns {string|null}
+		 * @return {string|null}
 		 */
 		defaultActionListener() {
 			return this.defaultAction ? 'figure-click' : null
@@ -275,8 +285,8 @@ export default {
 		/**
 		 * Can this tab be displayed ?
 		 *
-		 * @param {Object} tab a registered tab
-		 * @returns {boolean}
+		 * @param {object} tab a registered tab
+		 * @return {boolean}
 		 */
 		canDisplay(tab) {
 			return tab.enabled(this.fileInfo)
@@ -302,8 +312,8 @@ export default {
 		 * Copied from https://github.com/nextcloud/server/blob/16e0887ec63591113ee3f476e0c5129e20180cde/apps/files/js/filelist.js#L1377
 		 * TODO: We also need this as a standalone library
 		 *
-		 * @param {Object} fileInfo the fileinfo
-		 * @returns {string} Url to the icon for mimeType
+		 * @param {object} fileInfo the fileinfo
+		 * @return {string} Url to the icon for mimeType
 		 */
 		getIconUrl(fileInfo) {
 			const mimeType = fileInfo.mimetype || 'application/octet-stream'
@@ -341,7 +351,7 @@ export default {
 		 * Toggle favourite state
 		 * TODO: better implementation
 		 *
-		 * @param {Boolean} state favourited or not
+		 * @param {boolean} state favourited or not
 		 */
 		async toggleStarred(state) {
 			try {
@@ -397,7 +407,7 @@ export default {
 		 * Open the sidebar for the given file
 		 *
 		 * @param {string} path the file path to load
-		 * @returns {Promise}
+		 * @return {Promise}
 		 * @throws {Error} loading failure
 		 */
 		async open(path) {
@@ -446,6 +456,7 @@ export default {
 
 		/**
 		 * Allow to set the Sidebar as fullscreen from OCA.Files.Sidebar
+		 *
 		 * @param {boolean} isFullScreen - Wether or not to render the Sidebar in fullscreen.
 		 */
 		setFullScreenMode(isFullScreen) {

apps/files/src/views/TemplatePicker.vue

@@ -110,7 +110,8 @@ export default {
 	computed: {
 		/**
 		 * Strip away extension from name
-		 * @returns {string}
+		 *
+		 * @return {string}
 		 */
 		nameWithoutExt() {
 			return this.name.indexOf('.') > -1 ? this.name.split('.').slice(0, -1).join('.') : this.name
@@ -132,7 +133,8 @@ export default {
 
 		/**
 		 * Style css vars bin,d
-		 * @returns {Object}
+		 *
+		 * @return {object}
 		 */
 		style() {
 			return {
@@ -148,6 +150,7 @@ export default {
 	methods: {
 		/**
 		 * Open the picker
+		 *
 		 * @param {string} name the file name to create
 		 * @param {object} provider the template provider picked
 		 */
@@ -187,6 +190,7 @@ export default {
 
 		/**
 		 * Manages the radio template picker change
+		 *
 		 * @param {number} fileid the selected template file id
 		 */
 		onCheck(fileid) {