Skip to content

[stable21] Disable HEIC image preview provider for performance concerns #28080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukasReschke merged 1 commit into from
Jul 21, 2021
Merged

[stable21] Disable HEIC image preview provider for performance concerns #28080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Disable HEIC image preview provider for performance concerns 
Signed-off-by: tobiasKaminsky <[email protected]>
  • Loading branch information
@tobiasKaminsky @backportbot
tobiasKaminsky authored and backportbot[bot] committed Jul 21, 2021
commit cddc18d52717fff92e0491b337999312cdd92b88
3 changes: 1 addition & 2 deletions config/config.sample.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1046,6 +1046,7 @@
* concerns:
*
* - OC\Preview\Illustrator
* - OC\Preview\HEIC
* - OC\Preview\Movie
* - OC\Preview\MSOffice2003
* - OC\Preview\MSOffice2007
Expand All @@ -1063,7 +1064,6 @@
*
* - OC\Preview\BMP
* - OC\Preview\GIF
* - OC\Preview\HEIC
* - OC\Preview\JPEG
* - OC\Preview\MarkDown
* - OC\Preview\MP3
Expand All @@ -1077,7 +1077,6 @@
'OC\Preview\PNG',
'OC\Preview\JPEG',
'OC\Preview\GIF',
'OC\Preview\HEIC',
'OC\Preview\BMP',
'OC\Preview\XBitmap',
'OC\Preview\MP3',
Expand Down
3 changes: 1 addition & 2 deletions lib/private/PreviewManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,14 +278,14 @@ public function isAvailable(\OCP\Files\FileInfo $file) {
* - OC\Preview\JPEG
* - OC\Preview\GIF
* - OC\Preview\BMP
* - OC\Preview\HEIC
* - OC\Preview\XBitmap
* - OC\Preview\MarkDown
* - OC\Preview\MP3
* - OC\Preview\TXT
*
* The following providers are disabled by default due to performance or privacy concerns:
* - OC\Preview\Font
* - OC\Preview\HEIC
* - OC\Preview\Illustrator
* - OC\Preview\Movie
* - OC\Preview\MSOfficeDoc
Expand All @@ -311,7 +311,6 @@ protected function getEnabledDefaultProvider() {
Preview\JPEG::class,
Preview\GIF::class,
Preview\BMP::class,
Preview\HEIC::class,
Preview\XBitmap::class,
Preview\Krita::class,
Preview\WebP::class,
Expand Down