Skip to content

[stable21] hide download button for public preview of audio files #28097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szaimen merged 3 commits into from
Jul 22, 2021
Merged

[stable21] hide download button for public preview of audio files #28097

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2615cc
hide download button for public preview of audio files
fstorz Jun 25, 2021
fd20c27
Add comment linking to PR
fstorz Jul 19, 2021
34973fa
Remove trailing whitespace from comment
fstorz Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
hide download button for public preview of audio files 
When the option to hide downloads was selected at public link creation, the download button can be hidden by the audio html attribute controlsList="nodownload"

Signed-off-by: Florian Storz <[email protected]>
  • Loading branch information
@fstorz @backportbot
fstorz authored and backportbot[bot] committed Jul 21, 2021
commit e2615cc7efb84c5e673b977cf00b26f5e03fe330
3 changes: 2 additions & 1 deletion apps/files_sharing/templates/public.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@
<?php else: ?>
<?php if ($_['previewEnabled'] && substr($_['mimetype'], 0, strpos($_['mimetype'], '/')) == 'audio'): ?>
<div id="imgframe">
<audio tabindex="0" controls="" preload="none" style="width: 100%; max-width: <?php p($_['previewMaxX']); ?>px; max-height: <?php p($_['previewMaxY']); ?>px">
<audio tabindex="0" controls="" preload="none" style="width: 100%; max-width: <?php p($_['previewMaxX']); ?>px; max-height: <?php p($_['previewMaxY']); ?>px"
<?php if ($_['hideDownload']) { ?>controlsList="nodownload" <?php } ?>>
<source src="<?php p($_['downloadURL']); ?>" type="<?php p($_['mimetype']); ?>" />
</audio>
</div>
Expand Down