Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jul 22, 2021

Yet another shot at it.
Lots of outdated sections 😩

I didn't change the babel config as this is causing export issues and make everything not defined: dav is not defined OC is not defined etc etc. Most likely an issue with umd/commonjs exports


Followups:

  • Address the vue/no-mutating-props
    'vue/no-mutating-props': 'warn',
  • Migrate from jsunit to jest

skjnldsv added 2 commits July 22, 2021 13:06
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@juliusknorr

This comment has been minimized.

Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv marked this pull request as ready for review July 22, 2021 13:29
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 22, 2021
@skjnldsv
Copy link
Member Author

skjnldsv commented Jul 22, 2021

NODB failure is unrelated 🎉

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@szaimen
Copy link
Contributor

szaimen commented Jul 22, 2021

Did you push the production or dev js?

@skjnldsv
Copy link
Member Author

Did you push the production or dev js?

image

@szaimen
Copy link
Contributor

szaimen commented Jul 22, 2021

Did you push the production or dev js?

image

So this checks also if the correct js was pushed?

@skjnldsv
Copy link
Member Author

skjnldsv commented Jul 22, 2021

So this checks also if the correct js was pushed?

Yes, always have been 🔫 😉

- name: Check webpack build changes
run: |
bash -c "[[ ! \"`git status --porcelain `\" ]] || exit 1"
- name: Show changes on failure
if: failure()
run: |
git status
git --no-pager diff

@szaimen
Copy link
Contributor

szaimen commented Jul 22, 2021

okay and shouldn't we wait until the tests finish?

@skjnldsv
Copy link
Member Author

okay and shouldn't we wait until the tests finish?

Finished! 🛎️ 😁

@artonge
Copy link
Contributor

artonge commented Jul 22, 2021

Did you push the production or dev js?

image

So this checks also if the correct js was pushed?

Yes. It compiles in production mode, then checks if nothing as changed

@skjnldsv skjnldsv dismissed artonge’s stale review July 22, 2021 13:59

See comments

@artonge artonge merged commit 4301267 into master Jul 22, 2021
@artonge artonge deleted the feat/npm7 branch July 22, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants