Skip to content

Fix variable override in file view #28173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 1 commit into from
Jul 26, 2021
Merged

Fix variable override in file view #28173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix variabable override in file view 
Signed-off-by: Louis Chemineau <louis@chmn.me>
  • Loading branch information
@artonge
artonge committed Jul 26, 2021
commit 2cbc3e92452169444b2c2dc3659d6ca7542b32d3
10 changes: 5 additions & 5 deletions apps/files/lib/Controller/ViewController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,17 +221,17 @@ public function index($dir = '', $view = '', $fileid = null, $fileNotFound = fal

$navBarPositionPosition = 6;
$currentCount = 0;
foreach ($favElements['folders'] as $dir) {
$link = $this->urlGenerator->linkToRoute('files.view.index', ['dir' => $dir, 'view' => 'files']);
foreach ($favElements['folders'] as $favElement) {
$link = $this->urlGenerator->linkToRoute('files.view.index', ['dir' => $favElement, 'view' => 'files']);
$sortingValue = ++$currentCount;
$element = [
'id' => str_replace('/', '-', $dir),
'id' => str_replace('/', '-', $favElement),
'view' => 'files',
'href' => $link,
'dir' => $dir,
'dir' => $favElement,
'order' => $navBarPositionPosition,
'folderPosition' => $sortingValue,
'name' => basename($dir),
'name' => basename($favElement),
'icon' => 'files',
'quickaccesselement' => 'true'
];
Expand Down