Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 26, 2021

Bumps sass from 1.35.1 to 1.35.2.

Release notes

Sourced from sass's releases.

Dart Sass 1.35.2

To install Sass 1.35.2, download one of the packages below and add it to your PATH, or see the Sass website for full installation instructions.

Changes

  • Potentially breaking bug fix: Properly throw an error for Unicode ranges that have too many ?s after hexadecimal digits, such as U+12345??.

  • Potentially breaking bug fix: Fixed a bug where certain local variable declarations nested within multiple @if statements would incorrectly override a global variable. It's unlikely that any real stylesheets were relying on this bug, but if so they can simply add !global to the variable declaration to preserve the old behavior.

  • Potentially breaking bug fix: Fix a bug where imports of root-relative URLs (those that begin with /) in @import rules would be passed to both Dart and JS importers as file: URLs.

  • Properly support selector lists for the $extendee argument to selector.extend() and selector.replace().

  • Fix an edge case where @extend wouldn't affect a selector within a pseudo-selector such as :is() that itself extended other selectors.

  • Fix a race condition where meta.load-css() could trigger an internal error when running in asynchronous mode.

Dart API

  • Use the @internal annotation to indicate which Value APIs are available for public use.

See the full changelog for changes in earlier releases.

Changelog

Sourced from sass's changelog.

1.35.2

  • Potentially breaking bug fix: Properly throw an error for Unicode ranges that have too many ?s after hexadecimal digits, such as U+12345??.

  • Potentially breaking bug fix: Fixed a bug where certain local variable declarations nested within multiple @if statements would incorrectly override a global variable. It's unlikely that any real stylesheets were relying on this bug, but if so they can simply add !global to the variable declaration to preserve the old behavior.

  • Potentially breaking bug fix: Fix a bug where imports of root-relative URLs (those that begin with /) in @import rules would be passed to both Dart and JS importers as file: URLs.

  • Properly support selector lists for the $extendee argument to selector.extend() and selector.replace().

  • Fix an edge case where @extend wouldn't affect a selector within a pseudo-selector such as :is() that itself extended other selectors.

  • Fix a race condition where meta.load-css() could trigger an internal error when running in asynchronous mode.

Dart API

  • Use the @internal annotation to indicate which Value APIs are available for public use.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested review from a team, Pytal and julien-nc and removed request for a team July 26, 2021 20:00
@skjnldsv
Copy link
Member

@dependabot rebase

Bumps [sass](https://github.com/sass/dart-sass) from 1.35.1 to 1.35.2.
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md)
- [Commits](sass/dart-sass@1.35.1...1.35.2)

---
updated-dependencies:
- dependency-name: sass
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/stable22/sass-1.35.2 branch from d901b51 to 4eae0f7 Compare July 26, 2021 20:11
@MichaIng MichaIng added this to the Nextcloud 22.1.0 milestone Jul 26, 2021
@MichaIng
Copy link
Member

Drone test in sharing app fails to disable resharing two times. I remember this happened when doing the nextcloud-router bump bump on master. That was not yet done on stable22, but parts made it into the test builds or so?

@Pytal
Copy link
Member

Pytal commented Jul 26, 2021

Drone test in sharing app fails to disable resharing two times. I remember this happened when doing the nextcloud-router bump bump on master. That was not yet done on stable22, but parts made it into the test builds or so?

It's a recurring issue, but unrelated to the PR more often than not :) also unrelated to any specific branch like stable22

@Pytal
Copy link
Member

Pytal commented Jul 26, 2021

Unrelated CI failure

@Pytal Pytal merged commit b91ea46 into stable22 Jul 26, 2021
@Pytal Pytal deleted the dependabot/npm_and_yarn/stable22/sass-1.35.2 branch July 26, 2021 22:21
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 26, 2021
@skjnldsv skjnldsv mentioned this pull request Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants