-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fix folder size contained in S3 buckets #28185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix folder size contained in S3 buckets #28185
Conversation
1c04f22 to
e05aa2c
Compare
|
I investigated a similar issue with using Group Folders with the S3 storage with Vincent last week:
|
|
ref: nextcloud/groupfolders#1630 but probably not related because the latter is for group folders and the problem with S3 primary happens also without |
aea7a2e to
bdd1a35
Compare
|
/backport to stable22 |
|
/backport to stable21 |
If 'filesystem_check_changes' was set to never, the cached size was alway set to -1 (Pending) on every access Signed-off-by: Louis Chemineau <[email protected]>
bdd1a35 to
735fd94
Compare
PVince81
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, since the solution covers all the interesting cases let's move forward 👍
Folders contained in S3 bucket's are displayed with a size of "Pending".
The following command can get the real size to be displayed, but only for one refresh:
php occ files:scan --path "<S3 bucket path>"Rational (I might be wrong):
statmethod on the S3 folder, themtimeis always set to 'now'.hasUpdatedmethod fromFiles/Storage/Common.phpto always returnstrue,needsUpdatemethod inFiles/View.phpto always returnstruetoo.Files/Cache/Scanner.phpevery time the folder is acceceed. But it gets updated with a size of-1because the size for S3 folders is not getting computed and default to-1Need guidance on how and where we should address this issue :).