Skip to content

Revert accidentally dropped lines from Psalm baselines #28218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristophWurst merged 1 commit into from
Jul 28, 2021
Merged

Revert accidentally dropped lines from Psalm baselines #28218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions build/psalm-baseline-ocp.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@
<code>\OC</code>
</UndefinedClass>
</file>
<file src="lib/public/AppFramework/Http/Template/PublicTemplateResponse.php">
<InvalidScalarArgument occurrences="1"/>
</file>
<file src="lib/public/AppFramework/Http/ZipResponse.php">
<InvalidArrayAccess occurrences="5">
<code>$resource['internalName']</code>
Expand All @@ -75,6 +78,11 @@
<code>$jobList</code>
</MoreSpecificImplementedParamType>
</file>
<file src="lib/public/Contacts/IManager.php">
<UndefinedDocblockClass occurrences="1">
<code>IAddressBook[]</code>
</UndefinedDocblockClass>
</file>
<file src="lib/public/Dashboard/Model/WidgetTemplate.php">
<InvalidNullableReturnType occurrences="1">
<code>WidgetSetting</code>
Expand Down
45 changes: 42 additions & 3 deletions build/psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,9 @@
<InvalidScalarArgument occurrences="1">
<code>$chunkSize</code>
</InvalidScalarArgument>
<MissingFile occurrences="1">
<code>require '../../../../3rdparty/autoload.php'</code>
</MissingFile>
</file>
<file src="apps/dav/lib/AppInfo/Application.php">
<UndefinedFunction occurrences="1">
Expand Down Expand Up @@ -279,13 +282,15 @@
<code>$l10n-&gt;l('time', $dt, ['width' =&gt; 'short'])</code>
<code>$l10n-&gt;l('weekdayName', $dt, ['width' =&gt; 'abbreviated'])</code>
</FalsableReturnStatement>
<InvalidReturnStatement occurrences="4">
<InvalidReturnStatement occurrences="5">
<code>$l10n-&gt;l('date', $dt, ['width' =&gt; 'medium'])</code>
<code>$l10n-&gt;l('datetime', $dt, ['width' =&gt; 'medium|short'])</code>
<code>$l10n-&gt;l('time', $dt, ['width' =&gt; 'short'])</code>
<code>$l10n-&gt;l('weekdayName', $dt, ['width' =&gt; 'abbreviated'])</code>
<code>[$organizerEMail =&gt; $name]</code>
</InvalidReturnStatement>
<InvalidReturnType occurrences="4">
<InvalidReturnType occurrences="5">
<code>array|null</code>
<code>string</code>
<code>string</code>
<code>string</code>
Expand Down Expand Up @@ -357,6 +362,10 @@
<InvalidNullableReturnType occurrences="1">
<code>string</code>
</InvalidNullableReturnType>
<InvalidScalarArgument occurrences="2">
<code>[$recipient =&gt; $recipientName]</code>
<code>[$sender =&gt; $senderName]</code>
</InvalidScalarArgument>
<NullableReturnStatement occurrences="1">
<code>$lang-&gt;getValue()</code>
</NullableReturnStatement>
Expand Down Expand Up @@ -555,6 +564,11 @@
<code>\Sabre\Uri\split($principal)</code>
</UndefinedFunction>
</file>
<file src="apps/dav/lib/Connector/PublicAuth.php">
<InvalidScalarArgument occurrences="1">
<code>'DummyBasic realm="' . $this-&gt;realm . '"'</code>
</InvalidScalarArgument>
</file>
<file src="apps/dav/lib/Connector/Sabre/AnonymousOptionsPlugin.php">
<InvalidNullableReturnType occurrences="1">
<code>bool</code>
Expand Down Expand Up @@ -1104,7 +1118,7 @@
<InvalidReturnType occurrences="1">
<code>string</code>
</InvalidReturnType>
<InvalidScalarArgument occurrences="5">
<InvalidScalarArgument occurrences="6">
<code>$id</code>
<code>$id</code>
<code>$id</code>
Expand Down Expand Up @@ -1371,6 +1385,10 @@
</ParamNameMismatch>
</file>
<file src="apps/files_external/lib/Lib/Storage/SFTPReadStream.php">
<FalsableReturnStatement occurrences="2">
<code>false</code>
<code>false</code>
</FalsableReturnStatement>
<InvalidArgument occurrences="2">
<code>$this-&gt;handle</code>
<code>$this-&gt;handle</code>
Expand All @@ -1389,6 +1407,11 @@
</InvalidReturnType>
</file>
<file src="apps/files_external/lib/Lib/Storage/SFTPWriteStream.php">
<FalsableReturnStatement occurrences="3">
<code>false</code>
<code>false</code>
<code>false</code>
</FalsableReturnStatement>
<InvalidArgument occurrences="2">
<code>$this-&gt;handle</code>
<code>$this-&gt;handle</code>
Expand All @@ -1407,6 +1430,9 @@
</InvalidReturnType>
</file>
<file src="apps/files_external/lib/Lib/Storage/SMB.php">
<FalsableReturnStatement occurrences="1">
<code>false</code>
</FalsableReturnStatement>
<InvalidArgument occurrences="1">
<code>$files</code>
</InvalidArgument>
Expand Down Expand Up @@ -4129,6 +4155,11 @@
</InvalidReturnType>
</file>
<file src="lib/private/Files/Stream/SeekableHttpStream.php">
<FalsableReturnStatement occurrences="3">
<code>false</code>
<code>false</code>
<code>false</code>
</FalsableReturnStatement>
<InvalidPropertyAssignmentValue occurrences="2">
<code>$this-&gt;current</code>
<code>$this-&gt;current</code>
Expand Down Expand Up @@ -4421,6 +4452,11 @@
<code>mixed</code>
</LessSpecificImplementedReturnType>
</file>
<file src="lib/private/Memcache/Factory.php">
<TypeDoesNotContainType occurrences="1">
<code>$lockingCacheClass &amp;&amp; class_exists($distributedCacheClass)</code>
</TypeDoesNotContainType>
</file>
<file src="lib/private/Memcache/Memcached.php">
<RedundantCondition occurrences="1">
<code>method_exists(self::$cache, 'deleteMulti')</code>
Expand Down Expand Up @@ -5236,6 +5272,9 @@
<code>array</code>
</InvalidReturnType>
</file>
<file src="lib/public/AppFramework/Http/Template/PublicTemplateResponse.php">
<InvalidScalarArgument occurrences="1"/>
</file>
<file src="lib/public/AppFramework/Http/ZipResponse.php">
<InvalidArrayAccess occurrences="5">
<code>$resource['internalName']</code>
Expand Down