do not rewrite to top root index.php #28236
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxence Lange <[email protected]>
ArtificialOwl
requested review from
ChristophWurst,
LukasReschke and
juliusknorr
juliusknorr
reviewed
Aug 2, 2021
| RewriteRule ^$ /remote.php/webdav/ [L,R=302] | ||
| RewriteRule .* - [env=HTTP_AUTHORIZATION:%{HTTP:Authorization}] | ||
| RewriteRule ^\.well-known/carddav /remote.php/dav/ [R=301,L] | ||
| RewriteRule ^\.well-known/caldav /remote.php/dav/ [R=301,L] |
Member
There was a problem hiding this comment.
Would make sense then to also support this for the dav related well-known urls here
szaimen
added
2. developing
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that on a setup of Nextcloud in a subfolder of the website, even with a Redirect from /.well-known/ to /nextcloud/.well-known the current .htaccess will try to reach /index.php instead of looking the local index.php
At the root of the domain:
Rewrite will not work because the pathInfo is out of Nextcloud, the only way to fix this would be to add
in https://github.com/nextcloud/server/blob/master/lib/private/AppFramework/Http/Request.php#L770