[stable20] Fix autocompletion for usernames in comments

[kesselb]

Issue: Autocompletion of usernames in comments (e.g. for a file) does not work on Nextcloud 20

1
$('#commentsTabView').find('.newCommentForm .message') is empty on page load. It looks (to me with my very basic understanding of this app) that html for the comments tab is injected when the tab gets active. But _initAutoComplete happens much earlier and #commentsTabView does not exist.

2

server/apps/comments/src/commentstabview.js

Lines 191 to 215 in f1d96ed

	var s = this
	if (!_.isUndefined(this._autoCompleteRequestTimer)) {
	clearTimeout(this._autoCompleteRequestTimer)
	}
	this._autoCompleteRequestTimer = _.delay(function() {
	if (!_.isUndefined(this._autoCompleteRequestCall)) {
	this._autoCompleteRequestCall.abort()
	}
	this._autoCompleteRequestCall = $.ajax({
	url: OC.linkToOCS('core', 2) + 'autocomplete/get',
	data: {
	search: query,
	itemType: 'files',
	itemId: s.model.get('id'),
	sorter: 'commenters|share-recipients',
	limit: OC.appConfig.comments.maxAutoCompleteResults
	},
	beforeSend: function(request) {
	request.setRequestHeader('Accept', 'application/json')
	},
	success: function(result) {
	callback(result.ocs.data)
	}
	})
	}, 400)

_.delay(function() { this inside the closure is null. using s or bind(this) seems to fix it.

3
When editing a comment sometimes a error like happens. More often when you add another mention.

commentstabview.js:634 Uncaught (in promise) TypeError: Cannot read property 'removeClass' of undefined
    at success (commentstabview.js:634)
    at Object.options.success (backbone.js:649)
    at backbone-webdav.js:194

server/apps/comments/src/commentstabview.js

Lines 668 to 670 in f1d96ed

	var $row = $form.closest('.comment')
	$row.data('commentEl').removeClass('hidden')
	$row.remove()

Add, edit, delete comments still work afterwards. I'm not sure how to fix. Does anyone know what the above code is supposed to do? 🤷‍♂️

4
It's not possible to mention more than one person in one comment like Hi @Amy @Bender but Hi @Amy, Hi @Bender does work. It's a bit weird from a user point. Hopefully good enough for now ;)

[skjnldsv]

3
When editing a comment sometimes a error like happens. More often when you add another mention.

commentstabview.js:634 Uncaught (in promise) TypeError: Cannot read property 'removeClass' of undefined
    at success (commentstabview.js:634)
    at Object.options.success (backbone.js:649)
    at backbone-webdav.js:194

server/apps/comments/src/commentstabview.js

Lines 668 to 670 in f1d96ed

	var $row = $form.closest('.comment')
	$row.data('commentEl').removeClass('hidden')
	$row.remove()

Add, edit, delete comments still work afterwards. I'm not sure how to fix. Does anyone know what the above code is supposed to do?

I think it was adding a new view for the comment and deleting the old one to trigger everything again 🙈

[Pytal]

Works :)