Skip to content

[stable22] Add quota restrictions options #28256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Pytal merged 1 commit into from
Aug 23, 2021
Merged

[stable22] Add quota restrictions options #28256

Pytal merged 1 commit into from
Aug 23, 2021

Conversation

@julien-nc
Copy link
Member

@julien-nc julien-nc commented Jul 30, 2021

Manual backport of #28009

@julien-nc julien-nc added this to the Nextcloud 22.1.1 milestone Jul 30, 2021
@julien-nc
Copy link
Member Author

julien-nc commented Jul 30, 2021

/compile amend /

@nextcloud-command nextcloud-command force-pushed the enh/21045/stable22-quota-restrictions branch from e64ca81 to d7b2b16 Compare July 30, 2021 10:07
@julien-nc julien-nc force-pushed the enh/21045/stable22-quota-restrictions branch from d7b2b16 to e64ca81 Compare July 30, 2021 10:26
@julien-nc
Copy link
Member Author

julien-nc commented Jul 30, 2021

/compile amend /

@nextcloud-command nextcloud-command force-pushed the enh/21045/stable22-quota-restrictions branch from e64ca81 to 6aa8474 Compare July 30, 2021 10:44
@julien-nc julien-nc force-pushed the enh/21045/stable22-quota-restrictions branch 2 times, most recently from 82f4672 to e64ca81 Compare July 30, 2021 11:01
@julien-nc
Copy link
Member Author

julien-nc commented Jul 30, 2021

Hmmm I don't get how to fix the build CI here.

@julien-nc
Copy link
Member Author

julien-nc commented Jul 30, 2021

@Pytal Can something similar to #28202 be applied in stable22 too?

@Pytal
Copy link
Member

Pytal commented Jul 30, 2021 •
edited
Loading

@Pytal Can something similar to #28202 be applied in stable22 too?

Will make some backports :)

👉 #28274

@Pytal
Copy link
Member

Pytal commented Aug 4, 2021

@eneiluj stable22 backport #28274 has been merged :)

@Pytal
Copy link
Member

Pytal commented Aug 4, 2021

/compile amend /

@nextcloud-command nextcloud-command force-pushed the enh/21045/stable22-quota-restrictions branch from e64ca81 to becff85 Compare August 4, 2021 18:56
@skjnldsv

This comment has been minimized.

Sign in to view
@Pytal

This comment has been minimized.

Sign in to view
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2021
Merged
7 tasks
@skjnldsv

This comment has been minimized.

Sign in to view
@skjnldsv skjnldsv force-pushed the enh/21045/stable22-quota-restrictions branch from becff85 to 6d374d4 Compare August 19, 2021 12:47
@skjnldsv
Copy link
Member

skjnldsv commented Aug 19, 2021

/compile amend /

@nextcloud-command nextcloud-command force-pushed the enh/21045/stable22-quota-restrictions branch from 6d374d4 to 4a8dcea Compare August 19, 2021 12:59
@Pytal Pytal force-pushed the enh/21045/stable22-quota-restrictions branch from 4a8dcea to 26e1b9b Compare August 20, 2021 00:42
@Pytal
Copy link
Member

Pytal commented Aug 20, 2021

Previously chunkhashed files needed to be manually removed as amend does not remove files :)

@Pytal
Copy link
Member

Pytal commented Aug 20, 2021

/compile amend /

@Pytal @nextcloud-command
refs #21045 add app config to disable unlimited quota and to set max …
e3be5d4 
…quota

avoid unlimited quota as default_quota fallback value if unlimited quota is not allowed
avoid getting/setting/displaying unlimited default quota if not allowed
implement tests for unlimited quota restrictions

Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the enh/21045/stable22-quota-restrictions branch from 26e1b9b to e3be5d4 Compare August 20, 2021 00:52
@julien-nc
Copy link
Member Author

julien-nc commented Aug 23, 2021

The remaining failing CI check seems unrelated. Wow, maybe we can finally merge this 😁.
@Pytal @skjnldsv

@Pytal Pytal merged commit d84eed7 into stable22 Aug 23, 2021
@Pytal Pytal deleted the enh/21045/stable22-quota-restrictions branch August 23, 2021 16:29
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 23, 2021
@julien-nc julien-nc mentioned this pull request Aug 23, 2021
Merged
@blizzz blizzz mentioned this pull request Aug 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@szaimen szaimen Awaiting requested review from szaimen

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: files feature: settings

Projects

None yet

Milestone

Nextcloud 22.1.1

Development

Successfully merging this pull request may close these issues.

5 participants

@julien-nc @Pytal @skjnldsv @artonge