Check that php was compiled with argon2 support or that the php-sodium extensions is installed #28259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
reviewed
Jul 30, 2021
extensions is installed Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
work/carl/sodium-check
branch
from
f9587da to
8e51a5f
Compare
ChristophWurst
approved these changes
Jul 30, 2021
Member
|
backport? |
Member
Author
|
/backport to stable22 |
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable20 |
This was referenced Aug 2, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the case on rhel7 there PHP is not compiled with argon2 support and php-sodium is a weak dependency and not installed by default. On other distributions and rhel8, php-sodium or argon2 is already installed so there is less risk of it breaking.
Related to #21100
Signed-off-by: Carl Schwan [email protected]