fix UserController tests #28260
Merged
fix UserController tests #28260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rovided by mocks Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
added
bug
3. to review
julien-nc
requested review from
CarlSchwan,
artonge,
juliusknorr,
kesselb,
skjnldsv and
szaimen
kesselb
approved these changes
Jul 30, 2021
ChristophWurst
approved these changes
Jul 30, 2021
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Just as I wanted to look into this 🔥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which are failing because max_quota (new) app value is not provided by mocks.
I couldn't find a way to make this work by globally setting the return value of
IConfig::getAppValuein this test file... So it's done in each failing test.