Skip to content

[stable21] Hash cache key #28495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pytal merged 1 commit into from
Aug 18, 2021
Merged

[stable21] Hash cache key #28495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Hash cache key 
Signed-off-by: Christopher Ng <[email protected]>
  • Loading branch information
@Pytal @backportbot
Pytal authored and backportbot[bot] committed Aug 18, 2021
commit 7aa75c7b5ef4146e75539bcc432b074b9c9661af
5 changes: 3 additions & 2 deletions lib/private/User/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ public function get($uid) {
return $this->cachedUsers[$uid];
}

$cachedBackend = $this->cache->get($uid);
$cachedBackend = $this->cache->get(sha1($uid));
if ($cachedBackend !== null && isset($this->backends[$cachedBackend])) {
// Cache has the info of the user backend already, so ask that one directly
$backend = $this->backends[$cachedBackend];
Expand All @@ -175,7 +175,8 @@ public function get($uid) {
}

if ($backend->userExists($uid)) {
$this->cache->set($uid, $i, 300);
// Hash $uid to ensure that only valid characters are used for the cache key
$this->cache->set(sha1($uid), $i, 300);
return $this->getUserObject($uid, $backend);
}
}
Expand Down