Skip to content

Fix OC.linkToOCS so it works as before @nextcloud/router v2.0.0 #28506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
szaimen merged 4 commits into from
Aug 31, 2021
Merged

Fix OC.linkToOCS so it works as before @nextcloud/router v2.0.0 #28506

szaimen merged 4 commits into from
Aug 31, 2021

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 19, 2021 •
edited
Loading

Todo:

@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Aug 19, 2021
@nickvergessen nickvergessen added this to the Nextcloud 23 milestone Aug 19, 2021
@nickvergessen
Copy link
Member Author

nickvergessen commented Aug 19, 2021

Fixed the occurances

@skjnldsv
Copy link
Member

skjnldsv commented Aug 19, 2021 •
edited
Loading 

  OCA.Files_External.FileList tests
    loading file list for external storage
      ✗ render storage list
	Expected 'http://localhost:9876http://localhost/ocs/v2.php/apps/files_external/api/v1/mounts?format=json' to equal 'http://localhost:9876http://localhost/ocs/v1.php/apps/files_external/api/v1/mounts?format=json'.
	    at Object.<anonymous> (apps/files_external/tests/js/mountsfilelistSpec.js:119:24)

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 19, 2021
@nickvergessen nickvergessen added 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress 3. to review Waiting for reviews labels Aug 20, 2021
@nickvergessen
Copy link
Member Author

nickvergessen commented Aug 20, 2021

Fixed

@PVince81
Copy link
Member

PVince81 commented Aug 24, 2021

/compile amend /

@nextcloud-command nextcloud-command force-pushed the followup/27281/fix-oc-linktoocs branch from 12b5656 to d445380 Compare August 24, 2021 07:05
@szaimen
Copy link
Contributor

szaimen commented Aug 31, 2021

Conflicts

@nickvergessen nickvergessen force-pushed the followup/27281/fix-oc-linktoocs branch from d445380 to d8cbb9f Compare August 31, 2021 11:02
@nextcloud-command nextcloud-command force-pushed the followup/27281/fix-oc-linktoocs branch from d8cbb9f to ec4ace9 Compare August 31, 2021 11:04
@nickvergessen nickvergessen force-pushed the followup/27281/fix-oc-linktoocs branch from ec4ace9 to d8cbb9f Compare August 31, 2021 11:11
@nextcloud-command nextcloud-command force-pushed the followup/27281/fix-oc-linktoocs branch from d8cbb9f to 59ceb95 Compare August 31, 2021 11:11
@nickvergessen nickvergessen force-pushed the followup/27281/fix-oc-linktoocs branch from 59ceb95 to d8cbb9f Compare August 31, 2021 11:11
@szaimen szaimen merged commit ab592c9 into master Aug 31, 2021
@szaimen szaimen deleted the followup/27281/fix-oc-linktoocs branch August 31, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@kesselb kesselb Awaiting requested review from kesselb

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

6 participants

@nickvergessen @skjnldsv @PVince81 @szaimen @ChristophWurst