Skip to content

Conversation

@icewind1991
Copy link
Member

This mostly affects shared cache where $root starts as ''.

Note that the broken logic doesn't actually cause unexpected search results from showing up since the post-processing would filter these out, it does however make the search slower and messes with limit/offset

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Aug 23, 2021
@icewind1991 icewind1991 added this to the Nextcloud 23 milestone Aug 23, 2021
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

something to backport ?

@PVince81 PVince81 merged commit 6702c2b into master Aug 24, 2021
@PVince81 PVince81 deleted the jail-search-root-unjailed branch August 24, 2021 06:19
@icewind1991
Copy link
Member Author

/backport to stable22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants