Skip to content

Nmc 431-harmonizing of sharing permissions step 2 #28636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TSI-yogeshshejwadkar wants to merge 4 commits into from
Closed

Nmc 431-harmonizing of sharing permissions step 2 #28636

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
806bb2a
NMC-430 harmonizing of sharing permissions step #1
TSI-yogeshshejwadkar Aug 25, 2021
322ec38
removed upwanted code
TSI-yogeshshejwadkar Aug 25, 2021
03c46f2
NMC-431 added a new dropdown button under the display of the email-ad…
TSI-yogeshshejwadkar Aug 25, 2021
b687170
Update apps/files_sharing/src/components/SharingEntry.vue
TSI-yogeshshejwadkar Sep 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed upwanted code
  • Loading branch information
@TSI-yogeshshejwadkar
TSI-yogeshshejwadkar committed Aug 30, 2021
commit 322ec380850dc7aa54095ab171ab67ad48b6971f
65 changes: 18 additions & 47 deletions apps/files_sharing/src/components/SharingEntry.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,53 +45,24 @@
@close="onMenuClose">
<template v-if="share.canEdit">
<!-- folder -->
<template v-if="isFolder && fileHasCreatePermission && config.isPublicUploadEnabled">
<template v-if="isRemoteShare">
<!-- edit permission -->
<ActionCheckbox
ref="canEdit"
:checked.sync="canEdit"
:value="permissionsEdit"
:disabled="saving || !canSetEdit">
{{ t('files_sharing', 'Allow editing') }}
</ActionCheckbox>

<!-- create permission -->
<ActionCheckbox
ref="canCreate"
:checked.sync="canCreate"
:value="permissionsCreate"
:disabled="saving || !canSetCreate">
{{ t('files_sharing', 'Allow creating') }}
</ActionCheckbox>

<!-- delete permission -->
<ActionCheckbox
ref="canDelete"
:checked.sync="canDelete"
:value="permissionsDelete"
:disabled="saving || !canSetDelete">
{{ t('files_sharing', 'Allow deleting') }}
</ActionCheckbox>
</template>
<template v-else>
<ActionRadio :checked="sharePermissions === publicUploadRValue"
:value="publicUploadRValue"
:name="randomId"
:disabled="saving"
@change="togglePermissions">
{{ t('files_sharing', 'Read only') }}
</ActionRadio>

<ActionRadio :checked="sharePermissions === publicUploadRWValue"
:value="publicUploadRWValue"
:disabled="saving"
:name="randomId"
@change="togglePermissions">
{{ t('files_sharing', 'Allow upload and editing') }}
</ActionRadio>

</template>
<template v-if="isFolder && config.isPublicUploadEnabled">

<ActionRadio :checked="sharePermissions === publicUploadRValue"
:value="publicUploadRValue"
:name="randomId"
:disabled="saving"
@change="togglePermissions">
{{ t('files_sharing', 'Read only') }}
</ActionRadio>

<ActionRadio :checked="sharePermissions === publicUploadRWValue"
:value="publicUploadRWValue"
:disabled="saving"
:name="randomId"
@change="togglePermissions">
{{ t('files_sharing', 'Allow upload and editing') }}
</ActionRadio>

</template>
<!-- file -->
<template v-else>
Expand Down