Skip to content

Conversation

@TSI-sangramdesai
Copy link
Contributor

Guest view below changes done

  1. For Video separated download button form file name and size
  2. For Image separated download button form file name and size

Copy link

@Salvador1313 Salvador1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliusknorr
Copy link
Member

Please do not include the change in the 3rdparty submodule in here.

In addition the commit is missing a Signed-of-by message as described in https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md#sign-your-work

@juliusknorr juliusknorr requested review from a team, PVince81, jancborchardt, skjnldsv and szaimen and removed request for a team August 30, 2021 14:31
@juliusknorr juliusknorr changed the title NMC-552 NMC-552 Move filename/size out of the download button Aug 30, 2021
@juliusknorr juliusknorr added this to the Nextcloud 23 milestone Aug 30, 2021
@artonge
Copy link
Contributor

artonge commented Aug 31, 2021

I would also add some space above the downloadFile element. Adding the following in apps/files_sharing/css/public.scss should be enough:

.directDownload #downloadFile {
	...    
	margin-top: 16px;
}

@TSI-sangramdesai TSI-sangramdesai force-pushed the NMC-552 branch 2 times, most recently from 085235c to 773898d Compare September 1, 2021 13:03
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need DCO, else looks good :)

git rebase HEAD~6 --signoff
git push --force-with-lease origin NMC-552

@skjnldsv skjnldsv merged commit c37ed98 into nextcloud:master Sep 2, 2021
@welcome
Copy link

welcome bot commented Sep 2, 2021

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@skjnldsv

This comment has been minimized.

@skjnldsv

This comment has been minimized.

@nextcloud nextcloud deleted a comment from backportbot-nextcloud bot Sep 2, 2021
@nextcloud nextcloud deleted a comment from backportbot-nextcloud bot Sep 2, 2021
@skjnldsv

This comment has been minimized.

1 similar comment
@Pytal
Copy link
Member

Pytal commented Sep 2, 2021

/backport to stable22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants