-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
NMC-552 Move filename/size out of the download button #28643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Salvador1313
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Please do not include the change in the 3rdparty submodule in here. In addition the commit is missing a Signed-of-by message as described in https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md#sign-your-work |
|
I would also add some space above the .directDownload #downloadFile {
...
margin-top: 16px;
} |
085235c to
773898d
Compare
artonge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need DCO, else looks good :)
git rebase HEAD~6 --signoff
git push --force-with-lease origin NMC-552Signed-off-by: Sangramsinh Desai <[email protected]> Signed-off-by: [email protected] <[email protected]>
Signed-off-by: Sangramsinh Desai <[email protected]> Signed-off-by: [email protected] <[email protected]>
Signed-off-by: Sangramsinh Desai <[email protected]> Signed-off-by: [email protected] <[email protected]>
Signed-off-by: Sangramsinh Desai <[email protected]> Signed-off-by: [email protected] <[email protected]>
Signed-off-by: Sangramsinh Desai <[email protected]> Signed-off-by: [email protected] <[email protected]>
Signed-off-by: Sangramsinh Desai <[email protected]> Signed-off-by: [email protected] <[email protected]>
943ca47 to
bc6b496
Compare
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
/backport to stable22 |
Guest view below changes done