Skip to content

[stable22] NMC-552 Move filename/size out of the download button #28697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 6 commits into from
Sep 3, 2021
Merged

[stable22] NMC-552 Move filename/size out of the download button #28697

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e1aa27c
Guest view download button seperated for video
TSI-sangramdesai Aug 30, 2021
7929502
Guest view download button seperated for image
TSI-sangramdesai Aug 30, 2021
469f185
mimetype condition merged
TSI-sangramdesai Sep 1, 2021
03b14f0
space above the downloadFile element added
TSI-sangramdesai Sep 1, 2021
119010d
unwanted class removed
TSI-sangramdesai Sep 1, 2021
b1190a0
Duplicate code removed
TSI-sangramdesai Sep 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Duplicate code removed 
Signed-off-by: Sangramsinh Desai <[email protected]>
Signed-off-by: [email protected] <[email protected]>
  • Loading branch information
@TSI-sangramdesai @backportbot
TSI-sangramdesai authored and backportbot[bot] committed Sep 2, 2021
commit b1190a03f74efed2401f3cfbf284525be7fe6416
15 changes: 1 addition & 14 deletions apps/files_sharing/templates/public.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,20 +82,7 @@
<?php p($l->t('Download'))?>
</a>
</div>
<?php } ?>
<?php if(isset($_['mimetype'])){ ?>
<?php if (strpos($_['mimetype'], 'image') === 0) { ?>
<div class="directDownload">
<div>
<?php p($l->t('%s', [$_['filename']]))?> (<?php p($_['fileSize']) ?>)
</div>
<a href="<?php p($_['downloadURL']); ?>" id="downloadFile" class="button">
<span class="icon icon-download"></span>
<?php p($l->t('Download'))?>
</a>
</div>
<?php } ?>
<?php } ?>
<?php } ?>
<?php endif; ?>
<?php if ($_['previewURL'] === $_['downloadURL'] && !$_['hideDownload']): ?>
<div class="directDownload">
Expand Down