Skip to content

Remove 2FA exemption from PublicPage annotation #28725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukasReschke merged 2 commits into from
Sep 7, 2021
Merged

Remove 2FA exemption from PublicPage annotation #28725

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c1038b
Remove 2FA exemption from PublicPage annotation
LukasReschke Sep 6, 2021
8da6a9b
Adjust tests
LukasReschke Sep 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove 2FA exemption from PublicPage annotation 
Signed-off-by: Lukas Reschke <[email protected]>
  • Loading branch information
@LukasReschke
LukasReschke authored Sep 6, 2021
commit 7c1038bfb390c150f08937f62ff9a5c43bf9ebde
5 changes: 0 additions & 5 deletions core/Middleware/TwoFactorMiddleware.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,6 @@ public function __construct(Manager $twoFactorManager, Session $userSession, ISe
* @param string $methodName
*/
public function beforeController($controller, $methodName) {
if ($this->reflector->hasAnnotation('PublicPage')) {
// Don't block public pages
return;
}

if ($controller instanceof TwoFactorChallengeController
&& $this->userSession->getUser() !== null
&& !$this->reflector->hasAnnotation('TwoFactorSetUpDoneRequired')) {
Expand Down