Skip to content

Get filesize() if file_exists() #28768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 3 commits into from
Oct 18, 2021
Merged

Get filesize() if file_exists() #28768

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a25183
Get `filesize()` if `file_exists()`
solracsf Sep 9, 2021
8a8df49
Replace `file_exists()` method by `is_file()`
solracsf Oct 4, 2021
98eac0f
Simplify :)
solracsf Oct 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Get filesize() if file_exists() 
Should make sense.
  • Loading branch information
@solracsf
solracsf committed Oct 1, 2021
commit 3a25183b66d30d34ca10d3b2411d8d333face4fd
2 changes: 1 addition & 1 deletion lib/private/Files/Storage/Local.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ public function filetype($path) {
}

public function filesize($path) {
if ($this->is_dir($path)) {
if ($this->is_dir($path) || !$this->file_exists($path)) {
return 0;
}
$fullPath = $this->getSourcePath($path);
Expand Down