allow using of disabled password reset mechanism for special cases #28794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
requested review from
a team,
CarlSchwan,
ChristophWurst,
Pytal,
icewind1991 and
skjnldsv
and removed request for
a team
blizzz
force-pushed
the
fix/noid/guest-activation-pwd-reset-disabled
branch
from
7c786b4 to
a843d3c
Compare
- LostController has three endpoints - door opener email() still rejects - resetform(), reachable from mail, checks the token first and may report that password reset is disabled - setPassword() got its check removed as it is behind CSFR anyway and still requires a valid token - this allows special cases like activating a freshly created guest account Signed-off-by: Arthur Schiwon <[email protected]>
skjnldsv
approved these changes
Sep 14, 2021
Member
|
Nice catch! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Pytal
approved these changes
Sep 15, 2021
Pytal
added
4. to release
Member
|
/backport to stable22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that password reset is disabled
requires a valid token
fixes nextcloud/guests#85
How to reproduce
'lost_password_link' => 'disabled',