Skip to content

Nmc 434-changed the process of sharing #28832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TSI-yogeshshejwadkar wants to merge 8 commits into from
Closed

Nmc 434-changed the process of sharing #28832

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d22dbbd
NMC-434 - changed the process of file sharing for internal and extern…
TSI-yogeshshejwadkar Sep 14, 2021
0fe929c
updated conflict file
TSI-yogeshshejwadkar Sep 14, 2021
6fc67ca
Fixed the rectified issues and cleaned up the code
TSI-yogeshshejwadkar Sep 20, 2021
eeef5ec
updated test cases
TSI-yogeshshejwadkar Sep 23, 2021
8c88531
changed the label as suggested by nextcloud reviewer and fixed the issue
TSI-yogeshshejwadkar Oct 4, 2021
aaabf8a
changed the data tpe for hide download
TSI-yogeshshejwadkar Dec 23, 2021
bedcecf
disable hide download on file drop option
TSI-yogeshshejwadkar Feb 9, 2022
9d863e1
fixed issue related to disable hide download on selecting file drop o…
TSI-yogeshshejwadkar Feb 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
disable hide download on file drop option 
Signed-off-by: Yogesh Shejwadkar <[email protected]>
  • Loading branch information
@TSI-yogeshshejwadkar
TSI-yogeshshejwadkar committed Feb 9, 2022
commit bedcecf36559790b305362c5149456a22105f60f
5 changes: 4 additions & 1 deletion apps/files_sharing/src/components/SharingPermissions.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
{{ t('files_sharing', 'Advanced settings') }}
</label>
<ActionCheckbox :checked.sync="share.hideDownload"
:disabled="saving"
:disabled="saving || sharePermissions === publicUploadWValue"
@change="addHideDownload">
{{ t('files_sharing', 'Hide download') }}
</ActionCheckbox>
Expand Down Expand Up @@ -422,6 +422,9 @@ export default {
let permissions = 0
if (this.isExteranlShare) {
permissions = parseInt(event.target.value, 10)
if (permissions === OC.PERMISSION_CREATE) {
this.share.hideDownload = false
}
this.share.permissions = permissions
} else {
permissions = parseInt(event.target.value, 10)
Expand Down