Skip to content

Conversation

@luka-nextcloud
Copy link
Contributor

Signed-off-by: Luka Trovic [email protected]

@szaimen szaimen added the 2. developing Work in progress label Sep 20, 2021
@szaimen szaimen added this to the Nextcloud 23 milestone Sep 20, 2021
@julien-nc
Copy link
Member

julien-nc commented Sep 20, 2021

Any particular reason to put this in server?

This would probably be better to include those changes in https://github.com/nextcloud/richdocuments/blob/master/css/viewer.scss (or any relevant place in richdocument app) as it's the only app that will use the class. What do you think?

Also, be careful to only include the relevant files in your commits. You apparently built all Nextcloud JS stuff and committed everything.
Just in case, as an example, to fix this branch and only include core/css/icons.scss in your commit (Assuming you start with the current branch state):

cd /.../nextcloud-dev.git/
# cancel the commit
git reset HEAD~
# include one file in the next commit (staging area)
git add core/css/icons.scss
# commit without including all changes (no -a)
git commit -m "invert collabora icon in bright theme"
# force push the banch
git push origin invert-icon-color-in-bright-theme -f

@luka-nextcloud
Copy link
Contributor Author

@eneiluj I have moved those changes into richdocuments. I am closing this PR.

@szaimen szaimen removed this from the Nextcloud 23 milestone Sep 28, 2021
@skjnldsv skjnldsv deleted the invert-icon-color-in-bright-theme branch March 14, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants