Fall back to full file for video previews #28889
Merged
+29
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the first 5 MB are not enough to grab a useful frame for the thumbnail preview, fall back to reading the full file. Signed-off-by: Vincent Petry <[email protected]>
Member
Author
|
/backport to stable22 |
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable20 |
blizzz
approved these changes
Sep 20, 2021
artonge
approved these changes
Sep 20, 2021
Member
Author
it was that or a copy paste or a separate function |
This was referenced Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the first 5 MB are not enough to grab a useful frame for the
thumbnail preview, fall back to reading the full file.
Fixes #28694
To test you have to find a video file (mp4) that's big enough and for which thumbnail is not working.
I happened to have found one captured by my phone.
I've tested with master-key encryption as it will trigger the temporary file + use the first 5 MB logic.
Before the fix: some video files have no thumbnail.
After the fix: all video files have a thumbnail.