Make copy non-blocking for the encryption wrapper #28925
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
During an ownership transfer, if a file fails to be moved, then the transfer stops. This PR partly changes this behaviour for encryption error.
What this PR changes:
copyBetweenStoragemethod ofFiles/Storage/Wrapper/Encryption.phpTesting steps from a fresh install with encryption enabled:
1.mdto Alicephp occ encryption:disable2.mdto Alicephp occ encryption:enableoc_filecachefor2.md3.mdto Alicephp occ files:transfer-ownership alice bobfile:scan bobWithout this PR:
1.mdWith this PR (depending on the chosen solution below):
2.mdProblems
Alternative solutions
Decision
We won't merge this as it is too hacky.