Fix redirect during initial setup #28995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louis Chemineau <[email protected]>
szaimen
approved these changes
Sep 29, 2021
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
Tested locally and works. Thanks for fixing this :)
Contributor
|
/backport to stable22 |
Contributor
|
/backport to stable21 |
Contributor
|
/backport to stable20 |
PVince81
added
4. to release
Contributor
Author
|
Well, that was fast, thanks for the quick review :) |
This was referenced Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$this->request->getServerHost()return an empty string during the initial setup as it validate the request's domain against the trusted domains list.Combined with the recently added cache of
URLGenerator->baseUrl, this leads to a wrong redirect during the initial setup process.This PR adds a check to ensure that the cached
baseUrlis not used if it only contains the protocol.Fix: #27575