add 'supported'-label to all supported apps #29028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schiessle
added
3. to review
schiessle
force-pushed
the
add-supported-label-to-all-apps
branch
from
a506ec3 to
827bef0
Compare
Member
Author
|
php-cs check warnings seems to be unrelated to my changes |
MichaIng
reviewed
Oct 3, 2021
schiessle
force-pushed
the
add-supported-label-to-all-apps
branch
2 times, most recently
from
7c9756c to
059a302
Compare
…nloaded yet Signed-off-by: Bjoern Schiessle <[email protected]>
schiessle
force-pushed
the
add-supported-label-to-all-apps
branch
from
059a302 to
664bd58
Compare
Member
Author
|
All tests passed 🚀 Would be really nice to get this into Nc 23 🙂 |
MichaIng
approved these changes
Oct 7, 2021
Member
|
/backport to stable22 |
Member
|
/backport to stable21 |
Member
|
/backport to stable20 |
This was referenced Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment we add the "supported"-label only to apps which are already downloaded to the apps folder.
As a user with a valid Nextcloud subscription I would like to see directly which app is supported by my subscription, also if it is not yet downloaded from app.nextcloud.com.
This PR also check apps from apps.nextcloud.com against the list of supported apps and add the "supported" label if the app is covered by the users subscription.