Fix HTML entity rendering in file comments sidebar #29029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
requested review from
artonge and
szaimen
and removed request for
a team
This comment has been minimized.
This comment has been minimized.
Member
Author
|
/backport to stable22 |
Member
Author
|
/backport to stable21 |
nextcloud-command
force-pushed
the
fix/28243/render-html-entities
branch
from
a73caed to
b81f217
Compare
PVince81
reviewed
Oct 4, 2021
Pytal
force-pushed
the
fix/28243/render-html-entities
branch
from
b81f217 to
110190b
Compare
Pytal
changed the title
This comment has been minimized.
This comment has been minimized.
nextcloud-command
force-pushed
the
fix/28243/render-html-entities
branch
from
110190b to
347b27c
Compare
PVince81
reviewed
Oct 5, 2021
Merged
This comment has been minimized.
This comment has been minimized.
Pytal
force-pushed
the
fix/28243/render-html-entities
branch
from
347b27c to
09f8666
Compare
Member
Author
|
@tobiasKaminsky do clients render these correctly? |
This comment has been minimized.
This comment has been minimized.
nextcloud-command
force-pushed
the
fix/28243/render-html-entities
branch
from
09f8666 to
f06f1d6
Compare
Pytal
force-pushed
the
fix/28243/render-html-entities
branch
from
f06f1d6 to
e6abd38
Compare
Member
Author
|
/compile amend / |
nextcloud-command
force-pushed
the
fix/28243/render-html-entities
branch
from
e6abd38 to
f332ba2
Compare
Member
As far as I know this was only a problem on web ui side. |
Member
It seems the server returns double-encoding data, can you coordinate with @Pytal and @PVince81 to make sure @tobiasKaminsky ? :) |
Member
|
Android:
Desktop:
iOS:
|
CarlSchwan
approved these changes
Nov 8, 2021
Member
CarlSchwan
left a comment
CarlSchwan
left a comment
There was a problem hiding this comment.
Looks good to me, I will rebase it
CarlSchwan
force-pushed
the
fix/28243/render-html-entities
branch
2 times, most recently
from
b34dd35 to
ce614ea
Compare
Signed-off-by: Christopher Ng <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
CarlSchwan
force-pushed
the
fix/28243/render-html-entities
branch
from
ce614ea to
e5873a2
Compare
This was referenced Nov 8, 2021
Pytal
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #28243
This fix decodes HTML entities contained in comment messages and displaynames.
Some characters are double-encoded, e.g.
>-&gt;, so we decode the strings twice. Full character to encoded version map:>-&gt;double-encoded<-&lt;double-encoded&-&encoded"-"encoded'-'not encodedFurther work
Update backend XML encoder logic to address inconsistent encoding #29306