Skip to content

Reintroduce libxml_disable_entity_loader() calls #29094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
solracsf wants to merge 2 commits into from
Closed

Reintroduce libxml_disable_entity_loader() calls #29094

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ee3b84
Reintroduce libxml_disable_entity_loader() calls
solracsf Oct 6, 2021
bf26acc
Fix for installer
solracsf Oct 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Reintroduce libxml_disable_entity_loader() calls 
TL;DR https://blog.sonarsource.com/wordpress-xxe-security-vulnerability
  • Loading branch information
@solracsf
solracsf authored Oct 6, 2021
commit 8ee3b84e0a65667e9e2d1c1f16ff5a11f2efe1f7
10 changes: 3 additions & 7 deletions lib/private/App/InfoParser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,9 @@ public function parse($file) {
}

libxml_use_internal_errors(true);
if ((PHP_VERSION_ID < 80000)) {
$loadEntities = libxml_disable_entity_loader(false);
$xml = simplexml_load_file($file);
libxml_disable_entity_loader($loadEntities);
} else {
$xml = simplexml_load_file($file);
}
$loadEntities = @libxml_disable_entity_loader(false);
$xml = simplexml_load_file($file);
@libxml_disable_entity_loader($loadEntities);

if ($xml === false) {
libxml_clear_errors();
Expand Down