Skip to content

[stable22] Keep pw based auth tokens valid when pw-less login happens #29129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaIng merged 2 commits into from
Oct 12, 2021
Merged

[stable22] Keep pw based auth tokens valid when pw-less login happens #29129

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce834cb
draft to prevent the invalidation of pw based authn tokens on a pw le…
Jul 9, 2021
caae37e
add spaces around operators
Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add spaces around operators 
Signed-off-by: Tobias Assmann <[email protected]>
  • Loading branch information
@juliusknorr
Tobias Assmann authored and juliusknorr committed Oct 8, 2021
commit caae37e9e7edb366eda7cb70490b9504d927231a
2 changes: 1 addition & 1 deletion lib/private/Authentication/Listeners/UserLoggedInListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public function handle(Event $event): void {
}

// prevent setting an empty pw as result of pw-less-login
if ($event->getPassword()==='') {
if ($event->getPassword() === '') {
return;
}

Expand Down
2 changes: 1 addition & 1 deletion lib/private/Authentication/Token/PublicKeyTokenProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ public function updatePasswords(string $uid, string $password) {
$this->cache->clear();

// prevent setting an empty pw as result of pw-less-login
if ($password==='') {
if ($password === '') {
return;
}

Expand Down