Build instances of the calendar providers before using them #29231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
requested review from
blizzz,
kesselb,
miaulalala and
nickvergessen
kesselb
approved these changes
Oct 14, 2021
Contributor
kesselb
left a comment
kesselb
left a comment
There was a problem hiding this comment.
LGTM 👍
I think the calendar manager should have a method getCalendarProviders but might be yagni ;)
ChristophWurst
added
4. to release
Member
Author
And tested, right? I don't have the setup to verify my changes actually work :) |
Contributor
|
ChristophWurst
force-pushed
the
fix/calendar-providers-instances
branch
from
09ae9d2 to
707043b
Compare
2 tasks
What we get from the registration context are only the class names. We still have to load the classes before we can use them. Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
fix/calendar-providers-instances
branch
from
707043b to
c75a12c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What we get from the registration context are only the class names. We
still have to load the classes before we can use them.
Follow-up to #28970