Respect user enumeration settings in user status lists #29260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 15, 2021
Merged
Member
Author
|
After discussion with @nickvergessen, we decided to take this simpler approach for now to fix the underlying privacy issue #27879. |
mejo-
force-pushed
the
fix/user_status_enumeration2
branch
from
9d153b9 to
ced8e26
Compare
nickvergessen
approved these changes
Oct 18, 2021
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
As mentioned integration tests to ensure this is not flipped back at some point would be a nice topping to the PR
mejo-
force-pushed
the
fix/user_status_enumeration2
branch
3 times, most recently
from
114662e to
0a7bb12
Compare
mejo-
force-pushed
the
fix/user_status_enumeration2
branch
2 times, most recently
from
2170dd6 to
cc40020
Compare
nickvergessen
approved these changes
Oct 19, 2021
mejo-
force-pushed
the
fix/user_status_enumeration2
branch
4 times, most recently
from
85eb760 to
6e30710
Compare
So far, the functions to find user statuses listed didn't respect user enumeration settings (`shareapi_allow_share_dialog_user_enumeration` and `shareapi_restrict_user_enumeration_to_group` core app settings). Fix this privacy issue by returning an empty list in case `shareapi_allow_share_dialog_user_enumeration` is unset or `shareapi_restrict_user_enumeration_to_group` is set. In the long run, we might want to return users from common groups if `shareapi_restrict_user_enumeration_to_group` is set. It's complicated to implement this in a way that scales, though. See the discussion at #27879 (review) for details. Also, don't register the user_status dashboard widget at all if `shareapi_allow_share_dialog_user_enumeration` is unset or `shareapi_restrict_user_enumeration_to_group` is set. Fixes: #27122 Signed-off-by: Jonas Meurer <[email protected]>
Signed-off-by: Jonas Meurer <[email protected]>
mejo-
force-pushed
the
fix/user_status_enumeration2
branch
from
6e30710 to
65cfe9d
Compare
nickvergessen
approved these changes
Oct 20, 2021
Member
Author
|
/backport to stable22 |
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable20 |
|
The backport to stable21 failed. Please do this backport manually. |
|
The backport to stable20 failed. Please do this backport manually. |
|
The backport to stable22 failed. Please do this backport manually. |
LukasReschke
added a commit
that referenced
this pull request
Oct 25, 2021
Backport #29260: Respect user enumeration settings in user status lists
LukasReschke
added a commit
that referenced
this pull request
Oct 25, 2021
Backport #29260: Respect user enumeration settings in user status lists
LukasReschke
added a commit
that referenced
this pull request
Oct 25, 2021
Backport #29260: Respect user enumeration settings in user status lists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the functions to find user statuses listed didn't respect user
enumeration settings (
shareapi_allow_share_dialog_user_enumerationand
shareapi_restrict_user_enumeration_to_groupcore app settings).Fix this privacy issue by returning an empty list in case
shareapi_allow_share_dialog_user_enumerationis unset orshareapi_restrict_user_enumeration_to_groupis set.In the long run, we might want to return users from common groups if
shareapi_restrict_user_enumeration_to_groupis set. It's complicatedto implement this in a way that scales, though. See the discussion at
#27879 (review)
for details.
Also, don't register the user_status dashboard widget at all if
shareapi_allow_share_dialog_user_enumerationis unset orshareapi_restrict_user_enumeration_to_groupis set.Fixes: #27122
Signed-off-by: Jonas Meurer [email protected]