Skip to content

Deprecate PHP7.3 for Nextcloud 23 #29285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristophWurst merged 1 commit into from
Oct 18, 2021
Merged

Deprecate PHP7.3 for Nextcloud 23 #29285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Deprecate PHP7.3 for Nextcloud 23 
* 7.3 reaches EOL shortly after the release of 23.0.0
* Nextcloud 24 will require PHP7.4

Signed-off-by: Christoph Wurst <[email protected]>
  • Loading branch information
@ChristophWurst
ChristophWurst committed Oct 18, 2021
commit 4b8f8c5203da4d04cfd0ca76175130644e11d55b
2 changes: 1 addition & 1 deletion apps/settings/lib/Controller/CheckSetupController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ private function isUsedTlsLibOutdated() {
* @return bool
*/
protected function isPhpOutdated(): bool {
return PHP_VERSION_ID < 70300;
return PHP_VERSION_ID < 70400;
}

/**
Expand Down
4 changes: 2 additions & 2 deletions core/js/setupchecks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,9 +290,9 @@
type: OC.SetupChecks.MESSAGE_TYPE_INFO
})
}
if (data.phpSupported && data.phpSupported.version.substr(0, 3) === '7.2') {
if (data.phpSupported && data.phpSupported.version.substr(0, 3) === '7.3') {
messages.push({
msg: t('core', 'Nextcloud 20 is the last release supporting PHP 7.2. Nextcloud 21 requires at least PHP 7.3.'),
msg: t('core', 'Nextcloud 23 is the last release supporting PHP 7.3. Nextcloud 24 requires at least PHP 7.4.'),
type: OC.SetupChecks.MESSAGE_TYPE_INFO
})
}
Expand Down