Skip to content

[stable22] add a prefix index to filecache.path, attempt 2 #29324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 3 commits into from
Jan 5, 2022
Merged

[stable22] add a prefix index to filecache.path, attempt 2 #29324

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dcb99c4
add a prefix index to filecache.path
icewind1991 Mar 11, 2021
88cc1ba
disable path prefix index on postgresql for now
icewind1991 Aug 26, 2021
0aa5229
update @since for getDatabasePlatform
icewind1991 Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update @SInCE for getDatabasePlatform 
Signed-off-by: Robin Appelman <[email protected]>
  • Loading branch information
@icewind1991 @MichaIng
icewind1991 authored and MichaIng committed Nov 27, 2021
commit 0aa5229e84ce8e410cf35a4cfa2d2e5bd5e9175d
2 changes: 1 addition & 1 deletion lib/public/DB/ISchemaWrapper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public function getTableNamesWithoutPrefix();
* @return AbstractPlatform
*
* @throws Exception
* @since 23.0.0
* @since 22.2.4
*/
public function getDatabasePlatform();
Copy link
Member

@PVince81 PVince81 Oct 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

introducing a new API in a backport ?

Copy link
Member

@icewind1991 icewind1991 Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the @since to be correct for the backport but I don't know a clean way around it

Copy link
Member

@MichaIng MichaIng Nov 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we do about it now? A new API in a backport indeed looks strange, but otherwise it doesn't hurt and it seems to help with the issue of long/hanging file searches: #29377 #23835
I think people are waiting for this PR/backport.

Copy link
Member

@icewind1991 icewind1991 Dec 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we have done backported public api's in the past like this.

I don't see a way around adding this and no real downside

Copy link
Member

@MichaIng MichaIng Dec 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PVince81
Any objections?

}