Skip to content

add KerberosApacheAuth support to files_external #29349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 7 commits into from
Jan 20, 2022
Merged

add KerberosApacheAuth support to files_external #29349

skjnldsv merged 7 commits into from
Jan 20, 2022

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Oct 20, 2021 •
edited by icewind1991
Loading

@blizzz blizzz added this to the Nextcloud 23 milestone Oct 20, 2021
@skjnldsv skjnldsv modified the milestones: Nextcloud 23, Nextcloud 24 Oct 21, 2021
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 22, 2021
@skjnldsv skjnldsv mentioned this pull request Oct 25, 2021
Merged
25 tasks
@blizzz
Copy link
Member Author

blizzz commented Oct 29, 2021

/backport to stable22

@blizzz blizzz force-pushed the enh/noid/filesext_kerberos_apache_auth branch 2 times, most recently from 5434fa6 to 4a65590 Compare October 29, 2021 16:33
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2021
Merged
19 tasks
@blizzz blizzz added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 3, 2021
@blizzz blizzz requested review from a team, juliusknorr, nickvergessen and skjnldsv November 3, 2021 12:08
@blizzz blizzz force-pushed the enh/noid/filesext_kerberos_apache_auth branch from 7437443 to 69ab1bd Compare November 3, 2021 12:11
@blizzz
Copy link
Member Author

blizzz commented Nov 3, 2021

/rebase

@nextcloud-command nextcloud-command force-pushed the enh/noid/filesext_kerberos_apache_auth branch from 69ab1bd to f9965e8 Compare November 3, 2021 12:23
@blizzz blizzz mentioned this pull request Nov 3, 2021
Closed
18 tasks
@icewind1991
Copy link
Member

icewind1991 commented Nov 4, 2021

  • smb lib has been released and updated
  • Code has been adjusted for the differences between their smb patches and the released code

@blizzz blizzz marked this pull request as ready for review November 4, 2021 14:56
@skjnldsv skjnldsv mentioned this pull request Nov 8, 2021
Merged
23 tasks
@blizzz
Copy link
Member Author

blizzz commented Nov 25, 2021

/backport to stable23

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 25, 2021
@blizzz
Copy link
Member Author

blizzz commented Nov 25, 2021

@icewind1991 we got 1) OCA\Files_External\Tests\Storage\SmbTest::testNotifyGetChanges failing, but that should be fairly unaffected by the addition. Any idea?

@nickvergessen nickvergessen removed their request for review November 26, 2021 10:19
@blizzz blizzz modified the milestones: Nextcloud 23, Nextcloud 24 Nov 30, 2021
@skjnldsv
Copy link
Member

skjnldsv commented Dec 8, 2021

/backport to stable22

@skjnldsv
Copy link
Member

skjnldsv commented Dec 8, 2021

@icewind1991 we got 1) OCA\Files_External\Tests\Storage\SmbTest::testNotifyGetChanges failing, but that should be fairly unaffected by the addition. Any idea?

ping @icewind1991 :)

@blizzz
Copy link
Member Author

blizzz commented Jan 6, 2022

icewind1991/SMB#111 is also needed now (added as todo in the description)

blizzz and others added 6 commits January 20, 2022 16:08
@blizzz @icewind1991
add KerberosApacheAuth support to files_external
a96d461 
Signed-off-by: Arthur Schiwon <[email protected]>
@blizzz @icewind1991
add changes from Sebastian/dassIT and move default_realm to backend
a836aa3 
- Sebastian added the switch depending on the preg_match result and with it
  the fall back to login credentials
- I turned default_realm to a backend option (was previously suggested as
  system config key)

Signed-off-by: Arthur Schiwon <[email protected]>
@blizzz @icewind1991
do not use deprecated query() method
b391d57 
Signed-off-by: Arthur Schiwon <[email protected]>
@icewind1991
update icewind/smb to 3.5.1
a9619c3 
Signed-off-by: Robin Appelman <[email protected]>
@icewind1991
update to release smb lib
0bed61f 
Signed-off-by: Robin Appelman <[email protected]>
@icewind1991
update icewind/smb to 3.5.2
a33e1dc 
Signed-off-by: Robin Appelman <[email protected]>
@icewind1991 icewind1991 force-pushed the enh/noid/filesext_kerberos_apache_auth branch from 9965ba0 to a33e1dc Compare January 20, 2022 15:09
@icewind1991 icewind1991 force-pushed the enh/noid/filesext_kerberos_apache_auth branch from 96d0e3f to 4fe70de Compare January 20, 2022 17:34
@icewind1991
Copy link
Member

icewind1991 commented Jan 20, 2022

Also added an end-to-end test CI job

@skjnldsv
Copy link
Member

skjnldsv commented Jan 20, 2022 •
edited
Loading

Samba test is failing, but unrelated

@skjnldsv skjnldsv merged commit a3dc813 into master Jan 20, 2022
@skjnldsv skjnldsv deleted the enh/noid/filesext_kerberos_apache_auth branch January 20, 2022 19:10
This was referenced Jan 20, 2022
Merged
Merged
This was referenced Jul 8, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@come-nc come-nc come-nc approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: external storage

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

5 participants

@blizzz @icewind1991 @skjnldsv @come-nc